Re: [PATCHv2] emacs: derive correct timestamp in FCC unique name

diff --git a/f2/e2fdd828bed2994f3238bb497c1b1edd152ee3 b/f2/e2fdd828bed2994f3238bb497c1b1edd152ee3
new file mode 100644 (file)
index 0000000..56c26e1
--- /dev/null
+++ b/f2/e2fdd828bed2994f3238bb497c1b1edd152ee3
@@ -0,0 +1,103 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 11A20431FB6\r
+       for <notmuch@notmuchmail.org>; Thu, 14 Jun 2012 12:04:50 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 6FniGgvx646G for <notmuch@notmuchmail.org>;\r
+       Thu, 14 Jun 2012 12:04:48 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 892D7431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 14 Jun 2012 12:04:48 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 333721000D0; Thu, 14 Jun 2012 22:04:58 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jesse Rosenthal <jrosenthal@jhu.edu>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCHv2] emacs: derive correct timestamp in FCC unique name\r
+In-Reply-To: <87y5npg6gc.fsf@jhu.edu>\r
+References: <87d353ezyw.fsf@jhu.edu> <87y5npg6gc.fsf@jhu.edu>\r
+User-Agent: Notmuch/0.13.2+7~g2fb5bbc (http://notmuchmail.org) Emacs/23.1.1\r
+       (x86_64-redhat-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 14 Jun 2012 22:04:58 +0300\r
+Message-ID: <m2pq91iujp.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 14 Jun 2012 19:04:50 -0000\r
+\r
+On Thu, Jun 14 2012, Jesse Rosenthal <jrosenthal@jhu.edu> wrote:\r
+\r
+> Previously, the timestamp at the beginning of the FCC unique maildir\r
+> name was derived incorrectly, thanks to an integer overflow. This\r
+> changes the derivation of timestamp to use a float, and so will get\r
+> the number correct at least until 2038. (It is still formatted with\r
+> "%d" so it will show up as an integer.) Should we need to change it in\r
+> the next 26 years to take the unix millenium into account, it will be\r
+> invisible to users.\r
+>\r
+> This change is mostly a question of consistency, since the unique name\r
+> is arbitrary anyway. But since most people use timestamps, and that was\r
+> the original intention here as well, we might as well.\r
+>\r
+> Signed-off-by: Jesse Rosenthal <jrosenthal@jhu.edu>\r
+> ---\r
+\r
+\r
++1\r
+\r
+\r
+Tomi\r
+\r
+>  emacs/notmuch-maildir-fcc.el |    7 +++----\r
+>  1 file changed, 3 insertions(+), 4 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el\r
+> index dcfbc4b..07eedba 100644\r
+> --- a/emacs/notmuch-maildir-fcc.el\r
+> +++ b/emacs/notmuch-maildir-fcc.el\r
+> @@ -140,13 +140,12 @@ will NOT be removed or replaced."\r
+>                          t))\r
+>  \r
+>  (defun notmuch-maildir-fcc-make-uniq-maildir-id ()\r
+> -   (let* ((ct (current-time))\r
+> -      (timeid (+ (* (car ct) 65536) (cadr ct)))\r
+> -      (microseconds (car (cdr (cdr ct))))\r
+> +   (let* ((ftime (float-time))\r
+> +      (microseconds (mod (* 1000000 ftime) 1000000))\r
+>        (hostname (notmuch-maildir-fcc-host-fixer system-name)))\r
+>       (setq notmuch-maildir-fcc-count (+ notmuch-maildir-fcc-count 1))\r
+>       (format "%d.%d_%d_%d.%s"\r
+> -         timeid\r
+> +         ftime\r
+>           (emacs-pid)\r
+>           microseconds\r
+>           notmuch-maildir-fcc-count\r
+> -- \r
+> 1.7.9.5\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r