Re: [PATCH] tag: remove unused attribute from notmuch_tag_command() arguments

diff --git a/9f/8a098549243ce4c012df1880e19078e831e4f1 b/9f/8a098549243ce4c012df1880e19078e831e4f1
new file mode 100644 (file)
index 0000000..c693b2a
--- /dev/null
+++ b/9f/8a098549243ce4c012df1880e19078e831e4f1
@@ -0,0 +1,78 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8C8FF431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Feb 2012 11:36:03 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id YtSFF-ei3O7c for <notmuch@notmuchmail.org>;\r
+       Sun,  5 Feb 2012 11:36:03 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id C8362431FAE\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Feb 2012 11:36:02 -0800 (PST)\r
+Received: by bke11 with SMTP id 11so4919298bke.26\r
+       for <notmuch@notmuchmail.org>; Sun, 05 Feb 2012 11:36:01 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=JuT/H47U2kaymkhe/URCd1R1QLqVnBwmeWsrOwxgzHw=;\r
+       b=sCvaoIYBehCbCbeYAJNSUunsPl0g6l+PPyf8BCZTYDmCiHDd1Zk1/3Sjif8RX8fq/n\r
+       DuYd3PDWirtZ3OIEF423PxLzakjUf4RcSUajUUr/bwWonWDaqKGnMPI4Qr7xP1meSxKJ\r
+       vAGnNmGWxdkoUFxTWCnDAgnVspBTb9InDbo4M=\r
+Received: by 10.204.129.4 with SMTP id m4mr7063827bks.80.1328470561414;\r
+       Sun, 05 Feb 2012 11:36:01 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id d2sm37826928bky.11.2012.02.05.11.35.59\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Sun, 05 Feb 2012 11:36:00 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] tag: remove unused attribute from notmuch_tag_command()\r
+       arguments\r
+In-Reply-To: <87y5sisrja.fsf@rocinante.cs.unb.ca>\r
+References: <1327737753-18068-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <87y5sisrja.fsf@rocinante.cs.unb.ca>\r
+User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 05 Feb 2012 23:34:44 +0400\r
+Message-ID: <87aa4xhy5n.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 05 Feb 2012 19:36:03 -0000\r
+\r
+On Sat, 04 Feb 2012 07:37:45 -0500, David Bremner <david@tethera.net> wrote:\r
+> On Sat, 28 Jan 2012 12:02:33 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> > Argc and argv arguments are used in notmuch_tag_command() function.\r
+> > So unused attribute is not appropriate for them.\r
+> \r
+> pushed, \r
+> \r
+\r
+Are you sure?  I do not see it in master.\r
+\r
+Regards,\r
+  Dmitry\r
+\r
+> d\r