Re: [PATCH v3 0/4] cli: notmuch tag/restore refactoring

diff --git a/d1/2062a2a95e0d177c25d473c1253b2048253f75 b/d1/2062a2a95e0d177c25d473c1253b2048253f75
new file mode 100644 (file)
index 0000000..d53615d
--- /dev/null
+++ b/d1/2062a2a95e0d177c25d473c1253b2048253f75
@@ -0,0 +1,91 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6DC28431FAF\r
+       for <notmuch@notmuchmail.org>; Tue, 27 Mar 2012 13:01:25 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 2g47rz0KsJ0t for <notmuch@notmuchmail.org>;\r
+       Tue, 27 Mar 2012 13:01:23 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 07DA3431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 27 Mar 2012 13:01:22 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id D906B68055; Tue, 27 Mar 2012 23:01:19 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 0/4] cli: notmuch tag/restore refactoring\r
+In-Reply-To: <cover.1332795415.git.jani@nikula.org>\r
+References: <cover.1332795415.git.jani@nikula.org>User-Agent:\r
+ Notmuch/0.12+70~gce7ecf1      (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 27 Mar 2012 23:01:19 +0300\r
+Message-ID: <m28vilg6eo.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 27 Mar 2012 20:01:25 -0000\r
+\r
+On Tue, Mar 27 2012, Jani Nikula <jani@nikula.org> wrote:\r
+\r
+> v3 of id:"cover.1332702915.git.jani@nikula.org" with the following\r
+> mostly non-functional changes:\r
+>\r
+>  - add test for the current tagging behaviour in patch 1, and change the\r
+>    test in patch 2 when the behaviour is changed\r
+>  - handle the no tag changes case in _optimize_tag_query() in patch 2\r
+>  - add braces around the "tag_ops[tag_ops_count].remove = (argv[i][0] == '-');"\r
+>    assignment\r
+>  - document the tag_query() function a bit in patch 3\r
+>  - make tag_message() static in patch 4\r
+\r
+LGTM.\r
+\r
+>\r
+> BR,\r
+> Jani.\r
+\r
+Tomi\r
+\r
+>\r
+>\r
+> Jani Nikula (4):\r
+>   test: add test for both adding and removing a tag at the same time\r
+>   cli: refactor "notmuch tag" data structures for tagging operations\r
+>   cli: refactor "notmuch tag" query tagging into a separate function\r
+>   cli: refactor "notmuch restore" message tagging into a separate\r
+>     function\r
+>\r
+>  notmuch-restore.c |  148 ++++++++++++++++++++++++---------------------\r
+>  notmuch-tag.c     |  173 ++++++++++++++++++++++++++++-------------------------\r
+>  test/tagging      |    8 +++\r
+>  3 files changed, 178 insertions(+), 151 deletions(-)\r
+>\r
+> -- \r
+> 1.7.5.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r