vcs-snapshot.eclass: Detect unnecessary usage and complain

Signed-off-by: Michał Górny <mgorny@gentoo.org>

diff --git a/eclass/vcs-snapshot.eclass b/eclass/vcs-snapshot.eclass
index d3f7025fbb35bd7b478f1b759cb145d3fe31c8a4..05d963917e258d2b58d35b1059e6d647efc0776d 100644 (file)
--- a/eclass/vcs-snapshot.eclass
+++ b/eclass/vcs-snapshot.eclass
@@ -58,6 +58,7 @@ EXPORT_FUNCTIONS src_unpack
 vcs-snapshot_src_unpack() {
        debug-print-function ${FUNCNAME} "${@}"
 
+       local renamed_any=
        local f
 
        for f in ${A}
@@ -82,6 +83,7 @@ vcs-snapshot_src_unpack() {
                                        done
                                        die "${FUNCNAME}: Invalid directory structure in archive ${f}"
                                fi
+                               [[ ${topdirs[0]} != ${f%.tar*} ]] && renamed_any=1
 
                                mkdir "${destdir}" || die
                                # -o (--no-same-owner) to avoid restoring original owner
@@ -97,4 +99,14 @@ vcs-snapshot_src_unpack() {
                                ;;
                esac
        done
+
+       if [[ ! ${renamed_any} ]]; then
+               local w=eerror
+               [[ ${EAPI} == [0123456] ]] && w=eqawarn
+               "${w}" "${FUNCNAME} did not find any archives that needed renaming."
+               "${w}" "Please verify that its usage is really necessary, and remove"
+               "${w}" "the inherit if it is not."
+
+               [[ ${w} == eerror ]] && die "${FUNCNAME}: Unnecessary usage detected"
+       fi
 }