Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when...

diff --git a/d7/17d527e9e7a314e7bf8392adafa35ce6ae3f82 b/d7/17d527e9e7a314e7bf8392adafa35ce6ae3f82
new file mode 100644 (file)
index 0000000..769ecc6
--- /dev/null
+++ b/d7/17d527e9e7a314e7bf8392adafa35ce6ae3f82
@@ -0,0 +1,102 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 31269431E64\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 23:59:30 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id N9OMTtpT0Y1X for <notmuch@notmuchmail.org>;\r
+       Sun, 29 Jan 2012 23:59:29 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8E0D3431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 29 Jan 2012 23:59:29 -0800 (PST)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 8839E68056; Mon, 30 Jan 2012 09:59:32 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Pieter Praet <pieter@praet.org>, David Bremner <david@tethera.net>,\r
+       David Edmondson <dme@dme.org>, Jani Nikula <jani@nikula.org>\r
+Subject: Re: [PATCH] emacs: globally replace non-branching "(if COND (progn\r
+       ..." with "(when ..."\r
+In-Reply-To: <8739ax7jts.fsf@praet.org>\r
+References: <87k44uprvy.fsf@praet.org>\r
+       <1326532638-22068-1-git-send-email-pieter@praet.org>\r
+       <87y5ssxam7.fsf@zancas.localnet> <8739ax7jts.fsf@praet.org>\r
+User-Agent: Notmuch/0.11+116~g34d80c9 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 30 Jan 2012 09:59:32 +0200\r
+Message-ID: <m2zkd5ipsr.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 30 Jan 2012 07:59:30 -0000\r
+\r
+On Mon, 30 Jan 2012 08:03:59 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> On Sat, 28 Jan 2012 08:41:36 -0400, David Bremner <david@tethera.net> wrote:\r
+> > On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> > > Less code, same results, without sacrificing readability.\r
+> > > \r
+> > \r
+> > This looks OK, although the re-indenting makes these kind of changes\r
+> > painful to review (not that I'm suggesting we should re-indent, just\r
+> > some random complaining).\r
+> > \r
+> \r
+> You can use `diff-refine-hunk' to see what the actual changes are.\r
+> \r
+> Try this:\r
+> \r
+>   #+begin_src emacs-lisp\r
+>     (global-set-key (kbd "C-c /")\r
+>                     (lambda()\r
+>                       "Refine display of unified diff hunks"\r
+>                       (interactive)\r
+>                       (save-excursion\r
+>                         (goto-char (point-min))\r
+>                         (while (re-search-forward\r
+>                                 diff-hunk-header-re-unified\r
+>                                 nil t)\r
+>                           (diff-refine-hunk)))))\r
+>   #+end_src\r
+> \r
+> Work pretty much *anywhere*.\r
+> \r
+> Note: it does NOT work in `notmuch-show-mode' (not even with\r
+> `notmuch-wash-convert-inline-patch-to-part' disabled), but this is\r
+> easily solved by first running `notmuch-show-view-raw-message' ("V")\r
+> and `diff-mode' (to fontify the buffer)...\r
+\r
+What we need is 'notmuch-devel' minor mode which can do this, dme's\r
+notmuch patching tool, nmbug tag changes and everything...\r
+\r
+> \r
+> > d\r
+> \r
+> \r
+> Peace\r
+> \r
+> -- \r
+> Pieter\r
+\r
+Tomi\r