Re: [PATCH] emacs: Fix notmuch-message-mark-replied.

diff --git a/91/1adc9fe688f560b5a3039756aab2b7604e9689 b/91/1adc9fe688f560b5a3039756aab2b7604e9689
new file mode 100644 (file)
index 0000000..f89aa6c
--- /dev/null
+++ b/91/1adc9fe688f560b5a3039756aab2b7604e9689
@@ -0,0 +1,107 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C1A17431FAF\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Jul 2012 02:31:06 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id r3oDuFW+Wo6q for <notmuch@notmuchmail.org>;\r
+       Tue, 17 Jul 2012 02:31:06 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id E9748431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 17 Jul 2012 02:31:05 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 569BD10014D; Tue, 17 Jul 2012 12:31:15 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>,\r
+ Ingo Lohmar <i.lohmar@gmail.com>,     notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Fix notmuch-message-mark-replied.\r
+In-Reply-To: <87bojqrd6d.fsf@qmul.ac.uk>\r
+References: <87vcj8ckzm.fsf@acer.localhost.com> <87bojqrd6d.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.13.2+93~ge4fdd97 (http://notmuchmail.org) Emacs/23.1.1\r
+       (x86_64-redhat-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 17 Jul 2012 12:31:15 +0300\r
+Message-ID: <m2liii20po.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 17 Jul 2012 09:31:06 -0000\r
+\r
+On Sun, Jul 08 2012, Mark Walters wrote:\r
+\r
+> On Sun, 03 Jun 2012, Ingo Lohmar <i.lohmar@gmail.com> wrote:\r
+>> notmuch-message-mark-replied used "apply" to change message tags\r
+>> according to notmuch-message-replied-tags after sending a reply.  This\r
+>> works if the latter is a single-element list.  But with the recently\r
+>> changed format of tag changes, it breaks for multiple-element lists.\r
+>> Use "funcall" to properly pass the list of tag changes as a single\r
+>> argument.\r
+>\r
+> This looks correct to me: the bug is still in current master and this\r
+> does fix it.\r
+>\r
+> As Jamie says, it would be nice to have a test. Unfortunately, that is\r
+> beyond my test/emacs skills. \r
+>\r
+> Note this bug does not occur with default configuration but the option\r
+> is a defcustom option, and following the example in that option's\r
+> documentation will cause the problem.\r
+>\r
+> Since this patch has been around for over a month I think it should\r
+> probably be applied.\r
+\r
+I just tested this, without the patch setting multiple tags in reply\r
+fails with pretty ugly error message. with the patch setting one or\r
+multiple tags works. \r
+The fix is trivial (and obvious if one looks at it).\r
+\r
+I remove the needs-review tag.\r
+\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+\r
+Tomi\r
+\r
+>\r
+>> ---\r
+>>  emacs/notmuch-message.el |    2 +-\r
+>>  1 file changed, 1 insertion(+), 1 deletion(-)\r
+>>\r
+>> diff --git a/emacs/notmuch-message.el b/emacs/notmuch-message.el\r
+>> index 5964caa..d3738bf 100644\r
+>> --- a/emacs/notmuch-message.el\r
+>> +++ b/emacs/notmuch-message.el\r
+>> @@ -45,7 +45,7 @@ the \"inbox\" and \"todo\", you would set\r
+>>                             (concat "+" str)\r
+>>                           str))\r
+>>                       notmuch-message-replied-tags)))\r
+>> -   (apply 'notmuch-tag (notmuch-id-to-query (car (car rep))) tags)))))\r
+>> +   (funcall 'notmuch-tag (notmuch-id-to-query (car (car rep))) tags)))))\r
+>>  \r
+>>  (add-hook 'message-send-hook 'notmuch-message-mark-replied)\r
+>>  \r
+>> -- \r
+>> 1.7.10\r