--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id ABE9F431FB6\r
+ for <notmuch@notmuchmail.org>; Sat, 7 Jul 2012 23:15:44 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 5MUlXy5FhiDi for <notmuch@notmuchmail.org>;\r
+ Sat, 7 Jul 2012 23:15:44 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id BB77B431FAE\r
+ for <notmuch@notmuchmail.org>; Sat, 7 Jul 2012 23:15:43 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SnkmU-0001Uk-8f; Sun, 08 Jul 2012 07:15:42 +0100\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+ helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1SnkmT-0004cQ-R4; Sun, 08 Jul 2012 07:15:41 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Ingo Lohmar <i.lohmar@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Fix notmuch-message-mark-replied.\r
+In-Reply-To: <87vcj8ckzm.fsf@acer.localhost.com>\r
+References: <87vcj8ckzm.fsf@acer.localhost.com>\r
+User-Agent: Notmuch/0.13.2+61~gf708609 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 08 Jul 2012 07:15:38 +0100\r
+Message-ID: <87bojqrd6d.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: d3bd0b0e81ef06fb708c5da77aea86e1 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+ * domain\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 08 Jul 2012 06:15:45 -0000\r
+\r
+On Sun, 03 Jun 2012, Ingo Lohmar <i.lohmar@gmail.com> wrote:\r
+> notmuch-message-mark-replied used "apply" to change message tags\r
+> according to notmuch-message-replied-tags after sending a reply. This\r
+> works if the latter is a single-element list. But with the recently\r
+> changed format of tag changes, it breaks for multiple-element lists.\r
+> Use "funcall" to properly pass the list of tag changes as a single\r
+> argument.\r
+\r
+This looks correct to me: the bug is still in current master and this\r
+does fix it.\r
+\r
+As Jamie says, it would be nice to have a test. Unfortunately, that is\r
+beyond my test/emacs skills. \r
+\r
+Note this bug does not occur with default configuration but the option\r
+is a defcustom option, and following the example in that option's\r
+documentation will cause the problem.\r
+\r
+Since this patch has been around for over a month I think it should\r
+probably be applied.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+> ---\r
+> emacs/notmuch-message.el | 2 +-\r
+> 1 file changed, 1 insertion(+), 1 deletion(-)\r
+>\r
+> diff --git a/emacs/notmuch-message.el b/emacs/notmuch-message.el\r
+> index 5964caa..d3738bf 100644\r
+> --- a/emacs/notmuch-message.el\r
+> +++ b/emacs/notmuch-message.el\r
+> @@ -45,7 +45,7 @@ the \"inbox\" and \"todo\", you would set\r
+> (concat "+" str)\r
+> str))\r
+> notmuch-message-replied-tags)))\r
+> - (apply 'notmuch-tag (notmuch-id-to-query (car (car rep))) tags)))))\r
+> + (funcall 'notmuch-tag (notmuch-id-to-query (car (car rep))) tags)))))\r
+> \r
+> (add-hook 'message-send-hook 'notmuch-message-mark-replied)\r
+> \r
+> -- \r
+> 1.7.10\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff