Re: [PATCH 2/4] dirent->d_type not available on Soalris

diff --git a/10/963ac328ad555d962ca6a008e23241232d1d45 b/10/963ac328ad555d962ca6a008e23241232d1d45
new file mode 100644 (file)
index 0000000..c285dc9
--- /dev/null
+++ b/10/963ac328ad555d962ca6a008e23241232d1d45
@@ -0,0 +1,75 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id ED869431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 11 Apr 2012 11:57:49 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 0aNI4uxERNot for <notmuch@notmuchmail.org>;\r
+       Wed, 11 Apr 2012 11:57:49 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5AA66431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 11 Apr 2012 11:57:49 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id D8D1168055; Wed, 11 Apr 2012 21:57:45 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Vladimir.Marek@oracle.com, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/4] dirent->d_type not available on Soalris\r
+In-Reply-To: <1333989127-21523-1-git-send-email-Vladimir.Marek@oracle.com>\r
+References:\r
+ <CAMoJFUvHbSfXLTGKf2ZZnaLpLzZiHJ7W_ZUYZzm70n5mw4r1Kg@mail.gmail.com>\r
+       <1333989127-21523-1-git-send-email-Vladimir.Marek@oracle.com>User-Agent:\r
+       Notmuch/0.12+77~gee11800 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 11 Apr 2012 21:57:45 +0300\r
+Message-ID: <m2ty0qm6za.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Vladimir Marek <vlmarek@volny.cz>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 11 Apr 2012 18:57:50 -0000\r
+\r
+On Mon, Apr 09 2012, Vladimir.Marek@oracle.com wrote:\r
+\r
+> From: Vladimir Marek <vlmarek@volny.cz>\r
+>\r
+> The inspiration was taken from similar issue in mutt:\r
+> http://does-not-exist.org/mail-archives/mutt-dev/msg11290.html\r
+>\r
+> Signed-off-by: Vladimir Marek <vlmarek@volny.cz>\r
+> ---\r
+\r
+Code looks pretty good, but 2 issues\r
+\r
+1) Commit message should contain more verbose information what and \r
+   why something was done.\r
+\r
+2) Does these #ifdefs break code indenters such as uncrustify(1),\r
+   indent(1) and emacs(1) indent functionality.\r
+   (That used to happen but maybe these indenters are smarted today.\r
+\r
+Tomi\r
+\r
+>  notmuch-new.c |   28 ++++++++++++++++++++++++++++\r
+>  1 files changed, 28 insertions(+), 0 deletions(-)\r