Re: [PATCH v3 2/9] parse-time-string: add a date/time parser to notmuch

diff --git a/a6/fc12e495e0f6a9add0fd08f89e641a9f52b779 b/a6/fc12e495e0f6a9add0fd08f89e641a9f52b779
new file mode 100644 (file)
index 0000000..e04cc86
--- /dev/null
+++ b/a6/fc12e495e0f6a9add0fd08f89e641a9f52b779
@@ -0,0 +1,102 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 046E5431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 13 Sep 2012 05:07:50 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ScyUEzSTN-Fq for <notmuch@notmuchmail.org>;\r
+       Thu, 13 Sep 2012 05:07:49 -0700 (PDT)\r
+Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com\r
+       [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 0FE7F431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 13 Sep 2012 05:07:49 -0700 (PDT)\r
+Received: by qcpx40 with SMTP id x40so2153443qcp.26\r
+       for <notmuch@notmuchmail.org>; Thu, 13 Sep 2012 05:07:47 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type:x-gm-message-state;\r
+       bh=TkWYKbfMEBYF1D9Q9ebVgsTJFvUfB4GkF8f1oLusMLo=;\r
+       b=YnptO4/WWqbasf+ZN7KNGdYA/xRfmfGyXlIgsa8nCmr5eLIu7dMlCFTCpeKIkjLCnn\r
+       kUCMpZXKGFz0RgxFLF8ODXCzR/rIJCO+GGhXPJjCoAu5afCnruhMigv1Yykt5H/vKD5o\r
+       EYAzQUnx3jLjAkn0CGniGue00Z3xfKHDd0HUfIZd5X/yVmEQg8imJlHjm5dR+vHB5hEy\r
+       d408pC5aXWa8IJmBAeNHsKDdlH/BKCyH05DR7byb1IrLMDb1ZUD9FbNfQfSL3rWPmgcE\r
+       Abjj5+aYVE1l2lUahsA5GBY5hx3cPkWayO4VmpVzuHeieki0AQlmo7c5tiP09Oa+l3IX\r
+       hlvQ==\r
+Received: by 10.229.137.68 with SMTP id v4mr1040217qct.51.1347538067079;\r
+       Thu, 13 Sep 2012 05:07:47 -0700 (PDT)\r
+Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3])\r
+       by mx.google.com with ESMTPS id go9sm13819503qab.21.2012.09.13.05.07.43\r
+       (version=SSLv3 cipher=OTHER); Thu, 13 Sep 2012 05:07:45 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Michal Nazarewicz <mina86@mina86.com>, notmuch@notmuchmail.org,\r
+       David Bremner <david@tethera.net>\r
+Subject: Re: [PATCH v3 2/9] parse-time-string: add a date/time parser to\r
+       notmuch\r
+In-Reply-To: <xa1tvcfidvpe.fsf@mina86.com>\r
+References: <cover.1347484177.git.jani@nikula.org>\r
+       <89741ec9a9687fca8b30aa1a4877392d355dd3ce.1347484177.git.jani@nikula.org>\r
+       <xa1tvcfidvpe.fsf@mina86.com>\r
+User-Agent: Notmuch/0.14+43~gd23e654 (http://notmuchmail.org) Emacs/23.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 13 Sep 2012 14:07:35 +0200\r
+Message-ID: <878vcerurc.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Gm-Message-State:\r
+ ALoCoQmSVufALqY/8E8qDcmfq2u2TGu+4kc/a7qtkKfkMy+V7Bbhk/JWrWghk57BkOykd7QqA1D8\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 13 Sep 2012 12:07:50 -0000\r
+\r
+On Thu, 13 Sep 2012, Michal Nazarewicz <mina86@mina86.com> wrote:\r
+> On Wed, Sep 12 2012, Jani Nikula <jani@nikula.org> wrote:\r
+>> Add a date/time parser to notmuch, to be used for adding date range\r
+>> query support for notmuch lib later on. Add the parser to a directory\r
+>> of its own to make it independent of the rest of the notmuch code\r
+>> base.\r
+>>\r
+>> Signed-off-by: Jani Nikula <jani@nikula.org>\r
+>\r
+> Have you consider doing the same in bison?  I consider the code totally\r
+> unreadable and unmaintainable.\r
+\r
+I do not think you could easily do everything that this parser does in\r
+bison. But then I'm not an expert in bison, and I have zero ambition to\r
+become one. So I'm biased, and I'm open about it.\r
+\r
+Even so, if you're suggesting doing this in bison would make this\r
+totally readable and maintainable, I urge you to have a good look at\r
+[1]. Note that it also does less in more lines of code. (And using it\r
+as-is in notmuch has pretty much been turned down in the past.)\r
+\r
+Finally, I also suggest you actually read and review the code, pointing\r
+out concrete issues in readability or maintainability that you\r
+see. Especially since an earlier version has received comment "[I]t\r
+looks very nice to me. It is pleasantly nice to read." [2]. What you're\r
+doing is worthless bikeshedding otherwise.\r
+\r
+BR,\r
+Jani.\r
+\r
+[1] http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob_plain;f=lib/parse-datetime.y\r
+[2] id:"87mx86dlul.fsf@qmul.ac.uk"\r