fix up/remove XXX comments

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@2005 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/src/lib/crypto/des/cbc_cksum.c b/src/lib/crypto/des/cbc_cksum.c
index a7ce6c2290e236a34515982a6c2fdcc256b1e65f..eb42d8a20c548e231cfc188895c3f4e1cd75e593 100644 (file)
--- a/src/lib/crypto/des/cbc_cksum.c
+++ b/src/lib/crypto/des/cbc_cksum.c
@@ -63,11 +63,11 @@ OLDDECLARG(krb5_checksum *, cksum)
     switch (mit_des_key_sched ((krb5_octet *)key, schedule)) {
     case -1:
         cleanup();
-        return KRB5DES_BAD_KEYPAR;       /* XXX error code-bad key parity */
+        return KRB5DES_BAD_KEYPAR;
 
     case -2:
         cleanup();
-        return KRB5DES_WEAK_KEY;       /* XXX error code-weak key */
+        return KRB5DES_WEAK_KEY;
 
     default:
         ;

diff --git a/src/lib/crypto/des/des_int.h b/src/lib/crypto/des/des_int.h
index 6f689bc83d0cb18289bfa30bbb88739e0a1e8c2b..9f39fb6f6fbbb3e7849644f5fd59420ef409e1f7 100644 (file)
--- a/src/lib/crypto/des/des_int.h
+++ b/src/lib/crypto/des/des_int.h
@@ -183,7 +183,7 @@ extern unsigned long rev_swap_bit_pos_0 PROTOTYPE((unsigned long ));
 extern unsigned long swap_byte_bits PROTOTYPE((unsigned long ));
 extern unsigned long swap_long_bytes_bit_number PROTOTYPE((unsigned long ));
 #ifdef FILE
-/* XXX */
+/* XXX depends on FILE being a #define! */
 extern void test_set PROTOTYPE((FILE *, const char *, int, const char *, int));
 #endif
 

diff --git a/src/lib/crypto/des/fin_rndkey.c b/src/lib/crypto/des/fin_rndkey.c
index 089cd9c44310b8d5c0bb788386d98ababadf8fa3..87f24da6a3e01284e7817b0a6cb6a6968a1522c6 100644 (file)
--- a/src/lib/crypto/des/fin_rndkey.c
+++ b/src/lib/crypto/des/fin_rndkey.c
@@ -29,5 +29,5 @@ OLDDECLARG(krb5_pointer *, seed)
     memset((char *)*seed, 0, sizeof(mit_des_random_key_seed) );
     xfree(*seed);
     *seed = 0;
-    return 0;          /* XXX init_random_key */
+    return 0;
 }

diff --git a/src/lib/crypto/des/init_rkey.c b/src/lib/crypto/des/init_rkey.c
index 732265bc3fbb4ba231396e54248248be2c1c628d..0f5d088f0b31ef3b5b28a3be38ea92cf3e2c6c8c 100644 (file)
--- a/src/lib/crypto/des/init_rkey.c
+++ b/src/lib/crypto/des/init_rkey.c
@@ -35,7 +35,7 @@ OLDDECLARG(krb5_pointer *,seed)
 {
     mit_des_random_key_seed * p_seed;
     if (seedblock->keytype != KEYTYPE_DES)
-       return KRB5_BAD_KEYTYPE;          /* XXX error code bad keytype */
+       return KRB5_BAD_KEYTYPE;
     if ( !(p_seed = (mit_des_random_key_seed *) 
           malloc(sizeof(mit_des_random_key_seed))) ) 
        return ENOMEM;

diff --git a/src/lib/crypto/des/process_ky.c b/src/lib/crypto/des/process_ky.c
index f8b41d049d676a959f20a3b1a4ad2d8305da6edb..0f39a4359fdccbf6fce5575184d733a6c202fd13 100644 (file)
--- a/src/lib/crypto/des/process_ky.c
+++ b/src/lib/crypto/des/process_ky.c
@@ -43,7 +43,7 @@ OLDDECLARG(const krb5_keyblock *,keyblock)
     struct mit_des_ks_struct       *schedule;      /* pointer to key schedules */
     
     if (keyblock->length != sizeof (mit_des_cblock))
-       return KRB5_BAD_KEYSIZE;        /* XXX error code-bad key size */
+       return KRB5_BAD_KEYSIZE;
 
     if ( !(schedule = (struct mit_des_ks_struct *) malloc(sizeof(mit_des_key_schedule))) )
         return ENOMEM;
@@ -52,11 +52,11 @@ OLDDECLARG(const krb5_keyblock *,keyblock)
     switch (mit_des_key_sched (keyblock->contents, schedule)) {
     case -1:
        cleanup();
-       return KRB5DES_BAD_KEYPAR;      /* XXX error code-bad key parity */
+       return KRB5DES_BAD_KEYPAR;
 
     case -2:
        cleanup();
-       return KRB5DES_WEAK_KEY;        /* XXX error code-weak key */
+       return KRB5DES_WEAK_KEY;
 
     default:
        eblock->key = (krb5_keyblock *) keyblock;