Re: [PATCH 5/7] go: Partially bind notmuch_database_upgrade

diff --git a/fb/b30cb97a58a058aa0bd122bf418760ed1cccc1 b/fb/b30cb97a58a058aa0bd122bf418760ed1cccc1
new file mode 100644 (file)
index 0000000..f24cc1f
--- /dev/null
+++ b/fb/b30cb97a58a058aa0bd122bf418760ed1cccc1
@@ -0,0 +1,111 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 74FCB431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jul 2012 13:41:54 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id PQw-ulI-ggWT for <notmuch@notmuchmail.org>;\r
+       Wed, 18 Jul 2012 13:41:54 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU\r
+       [18.9.25.15])\r
+       by olra.theworths.org (Postfix) with ESMTP id 06A29431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jul 2012 13:41:53 -0700 (PDT)\r
+X-AuditID: 1209190f-b7f306d0000008b4-53-50071f91bfde\r
+Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
+       by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id AC.9A.02228.19F17005; Wed, 18 Jul 2012 16:41:53 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q6IKfrJC023535; \r
+       Wed, 18 Jul 2012 16:41:53 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6IKfqQo003472\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Wed, 18 Jul 2012 16:41:53 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1Srb4C-0001DI-3g; Wed, 18 Jul 2012 16:41:52 -0400\r
+Date: Wed, 18 Jul 2012 16:41:52 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Adrien Bustany <adrien@bustany.org>\r
+Subject: Re: [PATCH 5/7] go: Partially bind notmuch_database_upgrade\r
+Message-ID: <20120718204152.GU31670@mit.edu>\r
+References: <1342636475-16057-1-git-send-email-adrien@bustany.org>\r
+       <1342636475-16057-6-git-send-email-adrien@bustany.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1342636475-16057-6-git-send-email-adrien@bustany.org>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IR4hTV1p0ozx5gcOCQtsX6O2vZLK7fnMns\r
+       wOTx8cA9Jo9nq24xBzBFcdmkpOZklqUW6dslcGXM3/OQtWAZZ8WJxpAGxsPsXYycHBICJhKP\r
+       Tp5ng7DFJC7cWw9kc3EICexjlDh8/y4ThLOBUaLlTwMrhHOSSeLK7RaosiWMEi8aesBmsQio\r
+       Slw4dgNsFpuAhsS2/csZQWwRAXWJHZ3tYDazgLTEt9/NTCC2sICLxP3m52A2r4COxINp+1lB\r
+       bCGBaonDPS1sEHFBiZMzn7BA9GpJ3Pj3EqieA2zO8n8cIGFOAWeJzce+MIPYogIqElNObmOb\r
+       wCg0C0n3LCTdsxC6FzAyr2KUTcmt0s1NzMwpTk3WLU5OzMtLLdI10cvNLNFLTSndxAgOa0n+\r
+       HYzfDiodYhTgYFTi4X2wizVAiDWxrLgy9xCjJAeTkijvJyH2ACG+pPyUyozE4oz4otKc1OJD\r
+       jBIczEoivA8EgXK8KYmVValF+TApaQ4WJXHeqyk3/YUE0hNLUrNTUwtSi2CyMhwcShK8u+WA\r
+       GgWLUtNTK9Iyc0oQ0kwcnCDDeYCGF4PU8BYXJOYWZ6ZD5E8xKkqJ814DSQiAJDJK8+B6YWnn\r
+       FaM40CvCvBtAqniAKQuu+xXQYCagwdzFbCCDSxIRUlINjIxWCs2z/+68/dIkwa3hvCn/Sd17\r
+       zOcTX/swZTit0lhven3dk02fA4zsDb6YbTzR7R4Vs6FNwdv5y/JOoyJj0a9tHm9tZ/n4WNo7\r
+       XTC49+33/4UyhdxvFadt/H5l8kY2VunD2cx9N15z5R0qlu2yZmVU65mvuTH6b8eSMxeXF65c\r
+       xfnk9vptxUosxRmJhlrMRcWJAEgQkJIWAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 18 Jul 2012 20:41:54 -0000\r
+\r
+Quoth Adrien Bustany on Jul 18 at  9:34 pm:\r
+> This binding does not handle the progress callback, but at least allows\r
+> opening and upgrading a database if needed.\r
+> ---\r
+>  bindings/go/src/notmuch/notmuch.go |   13 ++++++++++++-\r
+>  1 files changed, 12 insertions(+), 1 deletions(-)\r
+> \r
+> diff --git a/bindings/go/src/notmuch/notmuch.go b/bindings/go/src/notmuch/notmuch.go\r
+> index d8b2739..384d5a5 100644\r
+> --- a/bindings/go/src/notmuch/notmuch.go\r
+> +++ b/bindings/go/src/notmuch/notmuch.go\r
+> @@ -296,7 +296,18 @@ func (self *Database) NeedsUpgrade() bool {\r
+>      return true\r
+>  }\r
+>  \r
+> -// TODO: notmuch_database_upgrade\r
+> +// TODO: Proper notmuch_database_upgrade\r
+> +/* Upgrade the current database.\r
+> + *\r
+> + * After opening a database in read-write mode, the client should\r
+> + * check if an upgrade is needed (notmuch_database_needs_upgrade) and\r
+> + * if so, upgrade with this function before making any modifications.\r
+> + */\r
+> +func (self *Database) Upgrade() Status {\r
+> +    st := Status(C.notmuch_database_upgrade(self.db, nil, nil));\r
+> +\r
+> +    return st;\r
+\r
+*gasp*  Semicolons!\r
+\r
+> +}\r
+>  \r
+>  /* Retrieve a directory object from the database for 'path'.\r
+>   *\r