Re: [PATCH v3 00/10] Solaris support

diff --git a/0c/7ed53a62e6b9c9ee0a83c456537deb3533a6c9 b/0c/7ed53a62e6b9c9ee0a83c456537deb3533a6c9
new file mode 100644 (file)
index 0000000..bfac8ad
--- /dev/null
+++ b/0c/7ed53a62e6b9c9ee0a83c456537deb3533a6c9
@@ -0,0 +1,100 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 879B7431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 15 Nov 2012 22:59:15 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id nfHpUGjw5x+r for <notmuch@notmuchmail.org>;\r
+       Thu, 15 Nov 2012 22:59:14 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 02D02431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 15 Nov 2012 22:59:13 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id D524A1000E2;\r
+       Fri, 16 Nov 2012 08:59:11 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Blake Jones <blakej@foo.net>\r
+Subject: Re: [PATCH v3 00/10] Solaris support\r
+In-Reply-To: <15993.1353004975@foo.net>\r
+References: <15993.1353004975@foo.net>\r
+User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Fri, 16 Nov 2012 08:59:11 +0200\r
+Message-ID: <m24nkqm3sw.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 16 Nov 2012 06:59:15 -0000\r
+\r
+On Thu, Nov 15 2012, Blake Jones <blakej@foo.net> wrote:\r
+\r
+>> $ gcc compat/have_strsep.c\r
+>> compat/have_strsep.c: In function "main":\r
+>> compat/have_strsep.c:7:21: error: expected identifier or "(" before "const"\r
+>> compat/have_strsep.c:9:29: error: "delim" undeclared (first use in this function)\r
+>> compat/have_strsep.c:9:29: note: each undeclared identifier is reported only once for each function it appears in\r
+>> zsh: exit 1     gcc compat/have_strsep.c\r
+>> \r
+>> --- It is very easy to spot the problem ;)\r
+>\r
+> Sigh, yes it is.  I started my Solaris port using some patches from\r
+> someone else who had done previous work on a Solaris port, and obviously\r
+> I didn't look at the patch very closely.  In fact, after fixing\r
+> have_strsep.c, I saw that I didn't even need it -- Solaris 11 has\r
+> strsep() in libc.  But I'd prefer to clean up this patch and leave the\r
+> compat version available for those compiling on older versions of\r
+> Solaris, if that's okay.\r
+\r
+It sure is okay -- the missing strsep() issue has been there before.\r
+\r
+>> $ gcc compat/check_asctime.c\r
+>> compat/check_asctime.c: In function "main":\r
+>> compat/check_asctime.c:15:5: error: too many arguments to function "asctime_r"\r
+>> In file included from compat/check_asctime.c:8:0:\r
+>> /usr/include/time.h:266:14: note: declared here\r
+>> zsh: exit 1     gcc compat/check_asctime.c\r
+>> \r
+>> --- the posix-semantics way uses the 2-arg format. \r
+>> \r
+>> The logic of the test setting in this file doesn't open to\r
+>> me. Why not test the same way as in getpwuid_r() case ?\r
+>\r
+> Yeah, that's clearly the right thing to do.  I was getting odd behavior\r
+> when I defined _POSIX_PTHREAD_SEMANTICS for getpwuid_r(), and it looks\r
+> like I fixed it in the wrong direction.\r
+>\r
+> Did you happen to notice any other issues besides these two?  I'd rather\r
+> not spam the list with my ten-patch set if there's other silly stuff\r
+> that needs cleaning up.\r
+\r
+Nope, just those 2 :)\r
+\r
+>\r
+> Thanks again for testing this.\r
+>\r
+> Blake\r
+\r
+Tomi\r