Re: [PATCH 2/2] cli: convert "notmuch new" to the argument parser

diff --git a/51/328048ad70860bb4b49a5236166caa453ad80c b/51/328048ad70860bb4b49a5236166caa453ad80c
new file mode 100644 (file)
index 0000000..6e4a671
--- /dev/null
+++ b/51/328048ad70860bb4b49a5236166caa453ad80c
@@ -0,0 +1,88 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id BC221431FBC\r
+       for <notmuch@notmuchmail.org>; Mon,  3 Dec 2012 14:35:51 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id bjZPdu+SDtG3 for <notmuch@notmuchmail.org>;\r
+       Mon,  3 Dec 2012 14:35:51 -0800 (PST)\r
+Received: from mail-la0-f53.google.com (mail-la0-f53.google.com\r
+       [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id D50F3431FAE\r
+       for <notmuch@notmuchmail.org>; Mon,  3 Dec 2012 14:35:50 -0800 (PST)\r
+Received: by mail-la0-f53.google.com with SMTP id w12so2826649lag.26\r
+       for <notmuch@notmuchmail.org>; Mon, 03 Dec 2012 14:35:49 -0800 (PST)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type:x-gm-message-state;\r
+       bh=AzDf/g76UAefjoqHgMwh1Dxd469ejr9vgyVfWu2SvTQ=;\r
+       b=geOghk6K48BHHumGg0CbjvkMMe4Mci4xwKxuP4h4Ik6zKXVKHQtjQdh3si0ZVewHCD\r
+       XECeoQekyHL4ipgKYs8eItgeA9DRn1y1EugJeUECvTQBM42yfRjtsX/VUvqxYTvydPSq\r
+       5NzvAoMXA5i+khV2ZKCCPQzwPj1Dub1Yy5ugm30frVN4xYaJhCCviW4dA2sPgkcVMRJ3\r
+       0ygPD6Rq19z8BBdtEMlQM8R6wDwyn8jb6auzwj2lpo0cqZj/nNsf3rS/eedvzzIQp/zd\r
+       51SL/KqlsO5ajcXxHm6sjlV1WOF2g8DoZ4HJ5LcrnUZFzw9LLeyn/VNrmlst5OJCbA3E\r
+       VoBQ==\r
+Received: by 10.112.47.168 with SMTP id e8mr4998525lbn.46.1354574149323;\r
+       Mon, 03 Dec 2012 14:35:49 -0800 (PST)\r
+Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi.\r
+       [80.223.81.27])\r
+       by mx.google.com with ESMTPS id ly18sm5886807lab.15.2012.12.03.14.35.47\r
+       (version=SSLv3 cipher=OTHER); Mon, 03 Dec 2012 14:35:48 -0800 (PST)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH 2/2] cli: convert "notmuch new" to the argument parser\r
+In-Reply-To: <20121203222844.GH1020@mit.edu>\r
+References:\r
+ <c4f2a1048763950dd14e13c99a4e7eb333be8c9d.1354568072.git.jani@nikula.org>\r
+       <e31ac6b2ceed533f8ac5386a010f4c052e09502e.1354568072.git.jani@nikula.org>\r
+       <20121203222844.GH1020@mit.edu>\r
+User-Agent: Notmuch/0.14+137~g9203c35 (http://notmuchmail.org) Emacs/23.4.1\r
+       (i686-pc-linux-gnu)\r
+Date: Tue, 04 Dec 2012 00:35:46 +0200\r
+Message-ID: <87y5he9325.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Gm-Message-State:\r
+ ALoCoQlZeuMIMi8+D+vPtzXryZPG1KT8HI43TKkaOGd4gt2TCYZ1NX4TmOm7G/mF0jl3jcrm9XJa\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 03 Dec 2012 22:35:51 -0000\r
+\r
+On Tue, 04 Dec 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+>> -    argc--; argv++; /* skip subcommand argument */\r
+>> +    notmuch_opt_desc_t options[] = {\r
+>> +   { NOTMUCH_OPT_BOOLEAN,  &add_files_state.verbose, "verbose", 'v', 0 },\r
+>> +   { NOTMUCH_OPT_BOOLEAN,  &add_files_state.debug, "debug", 'd', 0 },\r
+>> +   { NOTMUCH_OPT_BOOLEAN,  &no_hooks, "no-hooks", 'n', 0 },\r
+>\r
+> Not that the single character arguments matter right now, but '-n' is\r
+> often used for "dry-run", which could actually apply to notmuch new.\r
+\r
+Agreed, although I believe we'd have to review all of the single\r
+character arguments before actually enabling any of them. At least my\r
+choice of them has been rather whimsical. I'll leave this up to David to\r
+decide.\r
+\r
+BR,\r
+Jani.\r