Re: [PATCH 1/3] cli: refactor "notmuch tag" data structures for tagging operations

diff --git a/a5/238ce04f391683f3a3217cf604e41c3a2edd55 b/a5/238ce04f391683f3a3217cf604e41c3a2edd55
new file mode 100644 (file)
index 0000000..7ae8d67
--- /dev/null
+++ b/a5/238ce04f391683f3a3217cf604e41c3a2edd55
@@ -0,0 +1,74 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9FE42431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 26 Mar 2012 11:43:39 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.485\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.485 tagged_above=-999 required=5\r
+       tests=[DATE_IN_PAST_24_48=0.485] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id NJSvXod0gAbc for <notmuch@notmuchmail.org>;\r
+       Mon, 26 Mar 2012 11:43:39 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 06A1A431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 26 Mar 2012 11:43:38 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca ([131.202.240.238]\r
+ helo=rocinante.cs.unb.ca)     by tesseract.cs.unb.ca with esmtpsa\r
+ (TLS1.0:RSA_AES_256_CBC_SHA1:32)      (Exim 4.72) (envelope-from <bremner@unb.ca>)\r
+       id 1SCEtE-0008R8-8o; Mon, 26 Mar 2012 15:43:37 -0300\r
+Received: from bremner by rocinante.cs.unb.ca with local (Exim 4.77)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1SBWAl-00058I-Hu; Sat, 24 Mar 2012 14:58:43 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/3] cli: refactor "notmuch tag" data structures for\r
+       tagging operations\r
+In-Reply-To:\r
+ <992ada5cb2fa5f89d4f38b10d62f1c178b3174e2.1332604895.git.jani@nikula.org>\r
+References: <cover.1332604895.git.jani@nikula.org>\r
+       <992ada5cb2fa5f89d4f38b10d62f1c178b3174e2.1332604895.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.11.1+166~gd2ef4ed (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 24 Mar 2012 14:58:43 -0400\r
+Message-ID: <87pqc1ygf0.fsf@rocinante.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Spam_bar: /\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 26 Mar 2012 18:43:39 -0000\r
+\r
+On Sat, 24 Mar 2012 18:14:35 +0200, Jani Nikula <jani@nikula.org> wrote:\r
+> +    if (argv[i][0] == '+' || argv[i][0] == '-') {\r
+> +        tag_ops[tag_ops_count++] = (tag_operation_t) {\r
+> +            .tag = argv[i] + 1,\r
+> +            .remove = argv[i][0] == '-',\r
+> +        };\r
+\r
+I'm not sure if this is a worthwhile use of a C99. Wouldn't it be\r
+simpler to just use two assignments? and maybe increment the index\r
+after? Still 3 lines of code.\r
+\r
+Other than that, this patch looked ok to me.  I think it probably\r
+deserves a NEWS patch that the ordering behaviour changed. I do think\r
+the new order is more sensible, and the old one was never documented.\r
+\r
+\r
+d\r