Re: [PATCH] test: use (format "%S") to print nil in emacs test.

diff --git a/8b/d01f5e114dd25bbcb1edf898e41035a474fe08 b/8b/d01f5e114dd25bbcb1edf898e41035a474fe08
new file mode 100644 (file)
index 0000000..df28bba
--- /dev/null
+++ b/8b/d01f5e114dd25bbcb1edf898e41035a474fe08
@@ -0,0 +1,115 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D456B431FAF\r
+       for <notmuch@notmuchmail.org>; Fri, 31 Aug 2012 00:53:46 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id UhyVsXSnHZ5w for <notmuch@notmuchmail.org>;\r
+       Fri, 31 Aug 2012 00:53:46 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3151A431FAE\r
+       for <notmuch@notmuchmail.org>; Fri, 31 Aug 2012 00:53:46 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 3F34A100030;\r
+       Fri, 31 Aug 2012 10:53:54 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, david@tethera.net\r
+Subject: Re: [PATCH] test: use (format "%S") to print nil in emacs test.\r
+In-Reply-To: <20120831035227.GH11179@mit.edu>\r
+References: <1346375399-449-1-git-send-email-david@tethera.net>\r
+       <20120831035227.GH11179@mit.edu>\r
+User-Agent: Notmuch/0.14+11~gd9bf007 (http://notmuchmail.org) Emacs/24.1.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Fri, 31 Aug 2012 10:53:54 +0300\r
+Message-ID: <m23933lcod.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org, David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 31 Aug 2012 07:53:47 -0000\r
+\r
+On Fri, Aug 31 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> LGTM.  Alternatively, the test could be\r
+>   (null (notmuch-wash....))\r
+> with the correct answer being 't'.  That would avoid the awkward\r
+> detour through a string, but either way is good as long as this test\r
+> passes.\r
+\r
+I was going to vote this (null ... thing) but as the function returns\r
+nil when no match found it is more obvious th compare for that instead\r
+of "t".\r
+\r
+And, there is not much of a detour for the expected value nil, outputted\r
+as "nil" (without quotes) :).\r
+\r
+So: \r
+\r
+LGTM. "Alternatively, the test could" use (prin1 (...)) directly,\r
+"but either way is good as long as this test passes."\r
+\r
+Tomi\r
+\r
+>\r
+> Quoth david@tethera.net on Aug 30 at 10:09 pm:\r
+>> From: David Bremner <bremner@debian.org>\r
+>> \r
+>> The behaviour of "emacsclient --eval nil" changed from emacs23 to\r
+>> emacs24, and in emacs24 it prints 'nil' rather than an empty string.\r
+>> \r
+>> (format "%S" foo) produces a sexpr form of foo, and is consistent\r
+>> between the two versions.\r
+>> ---\r
+>> \r
+>> This fixes another test failure on emacs24. \r
+>> \r
+>> I guess maybe all test_emacs output could be canonicalized this way,\r
+>> but I suspect that would be pretty disruptive.\r
+>> \r
+>>  test/emacs-subject-to-filename |    6 +++---\r
+>>  1 file changed, 3 insertions(+), 3 deletions(-)\r
+>> \r
+>> diff --git a/test/emacs-subject-to-filename b/test/emacs-subject-to-filename\r
+>> index 176e685..a0ffdfe 100755\r
+>> --- a/test/emacs-subject-to-filename\r
+>> +++ b/test/emacs-subject-to-filename\r
+>> @@ -8,10 +8,10 @@ test_emacs '(ignore)'\r
+>>  \r
+>>  # test notmuch-wash-subject-to-patch-sequence-number (subject)\r
+>>  test_begin_subtest "no patch sequence number"\r
+>> -output=$(test_emacs '(notmuch-wash-subject-to-patch-sequence-number\r
+>> -      "[PATCH] A normal patch subject without numbers")'\r
+>> +output=$(test_emacs '(format "%S" (notmuch-wash-subject-to-patch-sequence-number\r
+>> +      "[PATCH] A normal patch subject without numbers"))'\r
+>>  )\r
+>> -test_expect_equal "$output" ""\r
+>> +test_expect_equal "$output" '"nil"'\r
+>>  \r
+>>  test_begin_subtest "patch sequence number #1"\r
+>>  output=$(test_emacs '(notmuch-wash-subject-to-patch-sequence-number\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r