Re: [PATCH 1/1] cli: propagate batch tagging warnings to exit value
authorJani Nikula <jani@nikula.org>
Sun, 13 Jan 2013 14:41:28 +0000 (16:41 +0200)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:53:05 +0000 (09:53 -0800)
f8/a3521c966d084591f4e511ca2be27660065497 [new file with mode: 0644]

diff --git a/f8/a3521c966d084591f4e511ca2be27660065497 b/f8/a3521c966d084591f4e511ca2be27660065497
new file mode 100644 (file)
index 0000000..4bc8415
--- /dev/null
@@ -0,0 +1,117 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id EEF71431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 13 Jan 2013 06:41:30 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.699\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5\r
+       tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id UiS8Z6APGodf for <notmuch@notmuchmail.org>;\r
+       Sun, 13 Jan 2013 06:41:30 -0800 (PST)\r
+Received: from mail-vb0-f49.google.com (mail-vb0-f49.google.com\r
+       [209.85.212.49]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 598F9431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 13 Jan 2013 06:41:30 -0800 (PST)\r
+Received: by mail-vb0-f49.google.com with SMTP id s24so2305779vbi.8\r
+       for <notmuch@notmuchmail.org>; Sun, 13 Jan 2013 06:41:28 -0800 (PST)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=mime-version:in-reply-to:references:date:message-id:subject:from:to\r
+       :cc:content-type:x-gm-message-state;\r
+       bh=8ntwEpF+ROVGgBq/UFcsTVfA6kMnU9QR/qGZ+1TifLs=;\r
+       b=N/axl9Cpwk7rWgnYvL868mVosLsHJygeTxUpkGqdNCGbp8OGwDJOYEQv9LxWFib18L\r
+       PdnuXQ+KwxsN0vuafBCFeXzdnInltg3l2L7z8/GGJQSIgeOviiBrsuWHaPIozJG08Tzg\r
+       XH8HjoT7O3pnrZ4WcFIBaXEkerZ6Rzr2AEyRWujKoUFxeSgHoTORAUa7ZWya5WcHWe9o\r
+       N4pd86r3/LX+xM7UQB8BVRIQ9m+mCtojYdXMNclVa1qQA54nYvNq2hTpsF/1tMuv4smw\r
+       XJwgcUNXcsQKFjNPZRI6eQHlrUCg8Tmo+4hOa7vas+xy3k6NOEp1RsDjrourk6/iIrW6\r
+       eqIQ==\r
+MIME-Version: 1.0\r
+Received: by 10.52.16.17 with SMTP id b17mr86696289vdd.86.1358088088610; Sun,\r
+       13 Jan 2013 06:41:28 -0800 (PST)\r
+Received: by 10.58.248.132 with HTTP; Sun, 13 Jan 2013 06:41:28 -0800 (PST)\r
+Received: by 10.58.248.132 with HTTP; Sun, 13 Jan 2013 06:41:28 -0800 (PST)\r
+In-Reply-To: <87fw25cfnw.fsf@zancas.localnet>\r
+References: <1357976414-7468-1-git-send-email-tomi.ollila@iki.fi>\r
+       <87fw25cfnw.fsf@zancas.localnet>\r
+Date: Sun, 13 Jan 2013 16:41:28 +0200\r
+Message-ID:\r
+ <CAB+hUn9rAbZt04R46WjQJqY29-X-WAi6qyTLmGWx=H6TNjwwHA@mail.gmail.com>\r
+Subject: Re: [PATCH 1/1] cli: propagate batch tagging warnings to exit value\r
+From: Jani Nikula <jani@nikula.org>\r
+To: David Bremner <david@tethera.net>\r
+Content-Type: multipart/alternative; boundary=bcaec50408e818663b04d32c8672\r
+X-Gm-Message-State:\r
+ ALoCoQlkQN3EjMqaaZmAaeEnAlB6TpgBFljsz+byI7lX0o6zglqS0zwrSS+8uv0mm8l9R8AyOoD+\r
+Cc: Tomi Ollila <tomi.ollila@iki.fi>, Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 13 Jan 2013 14:41:31 -0000\r
+\r
+--bcaec50408e818663b04d32c8672\r
+Content-Type: text/plain; charset=UTF-8\r
+\r
+On Jan 13, 2013 4:37 PM, "David Bremner" <david@tethera.net> wrote:\r
+>\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+> > In case last input for batch tagging was either invalid or skippable\r
+> > line, notmuch command exited with non-zero value.\r
+> > After this change if there is at least one invalid line, notmuch\r
+> > command will exit with non-zero value. Additionally, skipped lines\r
+> > (last or other) doesn't cause non-zero value to be returned.\r
+>\r
+> This looks OK. In a perfect world we'd have a test for return values.\r
+\r
+And distinct codes for warnings and errors... but can't have everything at\r
+once...\r
+\r
+J.\r
+\r
+> d\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
+\r
+--bcaec50408e818663b04d32c8672\r
+Content-Type: text/html; charset=UTF-8\r
+\r
+<p><br>\r
+On Jan 13, 2013 4:37 PM, &quot;David Bremner&quot; &lt;<a href="mailto:david@tethera.net">david@tethera.net</a>&gt; wrote:<br>\r
+&gt;<br>\r
+&gt; Tomi Ollila &lt;<a href="mailto:tomi.ollila@iki.fi">tomi.ollila@iki.fi</a>&gt; writes:<br>\r
+&gt;<br>\r
+&gt; &gt; In case last input for batch tagging was either invalid or skippable<br>\r
+&gt; &gt; line, notmuch command exited with non-zero value.<br>\r
+&gt; &gt; After this change if there is at least one invalid line, notmuch<br>\r
+&gt; &gt; command will exit with non-zero value. Additionally, skipped lines<br>\r
+&gt; &gt; (last or other) doesn&#39;t cause non-zero value to be returned.<br>\r
+&gt;<br>\r
+&gt; This looks OK. In a perfect world we&#39;d have a test for return values.</p>\r
+<p>And distinct codes for warnings and errors... but can&#39;t have everything at once...</p>\r
+<p>J.<br></p>\r
+<p>&gt; d<br>\r
+&gt; _______________________________________________<br>\r
+&gt; notmuch mailing list<br>\r
+&gt; <a href="mailto:notmuch@notmuchmail.org">notmuch@notmuchmail.org</a><br>\r
+&gt; <a href="http://notmuchmail.org/mailman/listinfo/notmuch">http://notmuchmail.org/mailman/listinfo/notmuch</a><br>\r
+</p>\r
+\r
+--bcaec50408e818663b04d32c8672--\r