Re: [PATCH] emacs: show: make id links respect window

diff --git a/81/3ae91ccf72259ccd43c55a80c0d7c1fafc9d45 b/81/3ae91ccf72259ccd43c55a80c0d7c1fafc9d45
new file mode 100644 (file)
index 0000000..1da075a
--- /dev/null
+++ b/81/3ae91ccf72259ccd43c55a80c0d7c1fafc9d45
@@ -0,0 +1,89 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id CB9A2431FBF\r
+       for <notmuch@notmuchmail.org>; Sat,  5 Jan 2013 13:50:51 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id wix3spaoWZt9 for <notmuch@notmuchmail.org>;\r
+       Sat,  5 Jan 2013 13:50:51 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 35860431FAE\r
+       for <notmuch@notmuchmail.org>; Sat,  5 Jan 2013 13:50:51 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 4FEBC10007D;\r
+       Sat,  5 Jan 2013 23:50:43 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>,\r
+ Mark Walters <markwalters1009@gmail.com>,     notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: show: make id links respect window\r
+In-Reply-To: <87bodgrh6a.fsf@zancas.localnet>\r
+References: <1355958602-16752-1-git-send-email-markwalters1009@gmail.com>\r
+       <87bodjfnt0.fsf@zancas.localnet> <87mwx2jsu0.fsf@qmul.ac.uk>\r
+       <87bodgrh6a.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.14+236~ge6d0259 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 05 Jan 2013 23:50:43 +0200\r
+Message-ID: <m2zk0ni9jg.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 05 Jan 2013 21:50:52 -0000\r
+\r
+On Wed, Dec 26 2012, David Bremner <david@tethera.net> wrote:\r
+\r
+> Mark Walters <markwalters1009@gmail.com> writes:\r
+>\r
+>>> I can imagine that people would want/like the "open in other window" \r
+>>> effect of the current code, even if the reason is a bug.\r
+>>\r
+>> That's definitely possible. I generally expect a mouse click to select\r
+>> the window I click and this feels counter intuitive. I think that some\r
+>> people might like an option "open this link in a new window" but I would\r
+>> guess that would like that whether they clicked or pressed RET on the\r
+>> button.\r
+>\r
+> I don't care much either way myself, but before we change notmuch-show\r
+> behaviour (effectively) to accomodate notmuch-pick, I'd like a bit more\r
+> feedback from other people.\r
+\r
+I tested the old behaviour -- split frame to 2 windows, one containing\r
+*scratch* and one *notmuch-hello*. Then I searched for 'obsoletes',\r
+chose last message (id:1356936162-2589-1-git-send-email-amdragon@mit.edu)\r
+moved point to *scratch* buffer and clicked the id: link -- and indeed,\r
+the *scratch* window was replaced.\r
+\r
+I didn't look or test Mark's patch as he stated:\r
+"The lisp is not pretty but seems to work." ;)\r
+... well, not entirely because of that but I trust it opens the message\r
+in window where the clicked link were and keeps point where it used to\r
+be before clicking (in case point was in different window).\r
+\r
+So, personally I'd like to see this fixed but I'm even less qualified\r
+to comment the implementation in the patch.\r
+\r
+\r
+> d\r
+\r
+Tomi\r