Don't bail out if postinst fails. Thanks to Brain Harring for the suggestion.
authorZac Medico <zmedico@gentoo.org>
Fri, 29 Jan 2010 18:49:23 +0000 (18:49 -0000)
committerZac Medico <zmedico@gentoo.org>
Fri, 29 Jan 2010 18:49:23 +0000 (18:49 -0000)
(trunk r15202)

svn path=/main/branches/2.1.7/; revision=15255

pym/portage/dbapi/vartree.py

index 13c9269a38fd12ce6b2b49ec7163f52830cba1eb..75558a12fe6e6a66944fe888c7db07fab525fb8d 100644 (file)
@@ -2847,11 +2847,11 @@ class dblink(object):
                finally:
                        self.settings.pop("PORTAGE_UPDATE_ENV", None)
 
-               # XXX: Decide how to handle failures here.
                if a != os.EX_OK:
+                       # It's stupid to bail out here, so keep going regardless of
+                       # phase return code.
                        showMessage(_("!!! FAILED postinst: ")+str(a)+"\n",
                                level=logging.ERROR, noiselevel=-1)
-                       return a
 
                downgrade = False
                for v in otherversions: