_validate_blockers: reference bug 128809
authorZac Medico <zmedico@gentoo.org>
Sun, 22 May 2011 21:20:56 +0000 (14:20 -0700)
committerZac Medico <zmedico@gentoo.org>
Thu, 26 May 2011 04:20:36 +0000 (21:20 -0700)
pym/_emerge/depgraph.py

index 6c126e1d68ec7e17a8ad25e73da8b024f973821b..4cb4593db2928b389fbe92f2398157dc7b9fa7a8 100644 (file)
@@ -3786,7 +3786,8 @@ class depgraph(object):
                """Remove any blockers from the digraph that do not match any of the
                packages within the graph.  If necessary, create hard deps to ensure
                correct merge order such that mutually blocking packages are never
-               installed simultaneously."""
+               installed simultaneously. Also add runtime blockers from all installed
+               packages if any of them haven't been added already (bug 128809)."""
 
                if "--buildpkgonly" in self._frozen_config.myopts or \
                        "--nodeps" in self._frozen_config.myopts:
@@ -3797,9 +3798,11 @@ class depgraph(object):
 
                if True:
                        # Pull in blockers from all installed packages that haven't already
-                       # been pulled into the depgraph.  This is not enabled by default
-                       # due to the performance penalty that is incurred by all the
-                       # additional dep_check calls that are required.
+                       # been pulled into the depgraph, in order to ensure that the are
+                       # respected (bug 128809). Due to the performance penalty that is
+                       # incurred by all the additional dep_check calls that are required,
+                       # blockers returned from dep_check are cached on disk by the
+                       # BlockerCache class.
 
                        # For installed packages, always ignore blockers from DEPEND since
                        # only runtime dependencies should be relevant for packages that