Re: [Patch v2 1/4] nmbug: use dump --format=batch-tag

diff --git a/1a/ea249ffedf31db6a6a867d2d3af08ed1b11d52 b/1a/ea249ffedf31db6a6a867d2d3af08ed1b11d52
new file mode 100644 (file)
index 0000000..6075505
--- /dev/null
+++ b/1a/ea249ffedf31db6a6a867d2d3af08ed1b11d52
@@ -0,0 +1,97 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D14B5431FB6\r
+       for <notmuch@notmuchmail.org>; Thu, 21 Feb 2013 03:52:29 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id F56bPX1Kp4Mu for <notmuch@notmuchmail.org>;\r
+       Thu, 21 Feb 2013 03:52:28 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 8F0E3431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 21 Feb 2013 03:52:28 -0800 (PST)\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1U8UhM-0005E1-Mx; Thu, 21 Feb 2013 07:52:25 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1U8UhG-0001vq-Tf; Thu, 21 Feb 2013 07:52:18 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [Patch v2 1/4] nmbug: use dump --format=batch-tag\r
+In-Reply-To: <m27gm2ax1k.fsf@guru.guru-group.fi>\r
+References: <1361399077-7737-1-git-send-email-david@tethera.net>\r
+       <1361399077-7737-2-git-send-email-david@tethera.net>\r
+       <m27gm2ax1k.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.15.2+32~g16aa65b (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 21 Feb 2013 07:52:18 -0400\r
+Message-ID: <87k3q151fx.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 21 Feb 2013 11:52:30 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+>\r
+> This patch series looks good to me (as far as I can understand, I did\r
+> not find the "silly bug" in your previous patch...)\r
+>\r
+\r
+Compare :\r
+\r
++    print $notmuch $A_action.$TAGPREFIX.$pair->{tag}, " -- ",\r
++      'id:'.$pair->{id};\r
+\r
+vs.\r
+\r
++    print $notmuch $D_action.$TAGPREFIX.$pair->{tag},\r
++      'id:'.$pair->{id};\r
+\r
+I obviously did not test that version very well.\r
+\r
+> Instead of mentioning that "calls are _not_ passed to shell" here,\r
+> that could be briefly mentioned just before system() calls in the\r
+> script -- and that definitely should not be 'At the moment' feature.\r
+\r
+Sure, the "At the moment" is meant to modify "relies". In the next\r
+patch, we stop relying on this feature of Perl.\r
+\r
+>\r
+> the system() function in perl(1) never pass execution through the\r
+> shell in case the args are list more than one arg:\r
+>\r
+\r
+right. that's what I meant by "is a documented feature of perl's system\r
+function"\r
+\r
+So I think we mean to say the same thing here; but I could I add a\r
+comment in this patch (to delete it in the next). Or maybe reword that\r
+commit message somehow.\r
+\r
+d\r