[PATCH 8/6] emacs: use message ids instead of thread id in `notmuch-show-operate...

diff --git a/26/05ba0c30ca06fc1d56590d54f7618ced287fd7 b/26/05ba0c30ca06fc1d56590d54f7618ced287fd7
new file mode 100644 (file)
index 0000000..9989c2a
--- /dev/null
+++ b/26/05ba0c30ca06fc1d56590d54f7618ced287fd7
@@ -0,0 +1,119 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 463C1431FB6\r
+       for <notmuch@notmuchmail.org>; Fri, 27 Jan 2012 22:00:18 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id PlDK9Cdm2WKO for <notmuch@notmuchmail.org>;\r
+       Fri, 27 Jan 2012 22:00:17 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 951F4431FAE\r
+       for <notmuch@notmuchmail.org>; Fri, 27 Jan 2012 22:00:17 -0800 (PST)\r
+Received: by bkbzt19 with SMTP id zt19so2289195bkb.26\r
+       for <notmuch@notmuchmail.org>; Fri, 27 Jan 2012 22:00:16 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:subject:date:message-id:x-mailer:in-reply-to:references;\r
+       bh=Xd7jtBqqqLhCHd8k0SN51BQ/VYr8IoXHNAu6YVKxuQw=;\r
+       b=tR8vVR5GKHbOlrUQ83JzRD7PSgdASn4tqwgkNpxS5pfjVPLv7DHmU5Gja2M2UXWIGz\r
+       RxKUBXHyi0ViDokKN6HgMT7QDZ9EuEOzD0XEtYctmW4nX7eqGdyxYkcVrTPTtB/JIvge\r
+       PZ3Siju56aJnQy9DN37atSZ17atu3RRomMDF4=\r
+Received: by 10.205.137.4 with SMTP id im4mr4612109bkc.136.1327730416251;\r
+       Fri, 27 Jan 2012 22:00:16 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id x20sm5831668bka.9.2012.01.27.22.00.15\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Fri, 27 Jan 2012 22:00:15 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH 8/6] emacs: use message ids instead of thread id in\r
+       `notmuch-show-operate-all'\r
+Date: Sat, 28 Jan 2012 09:59:07 +0400\r
+Message-Id: <1327730348-6466-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+X-Mailer: git-send-email 1.7.8.3\r
+In-Reply-To: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 28 Jan 2012 06:00:18 -0000\r
+\r
+Before the change, `notmuch-show-operate-all' used thread id for\r
+"notmuch tag" search.  This could result in tagging unexpected\r
+messages that were added to the thread after the notmuch-show buffer\r
+was created.  The patch changes `notmuch-show-operate-all' to use ids\r
+of shown messages to fix this.\r
+---\r
+ emacs/notmuch-show.el |   23 ++++++++++++++++++++++-\r
+ 1 files changed, 22 insertions(+), 1 deletions(-)\r
+\r
+diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+index 2ca4d92..e606224 100644\r
+--- a/emacs/notmuch-show.el\r
++++ b/emacs/notmuch-show.el\r
+@@ -1170,6 +1170,15 @@ All currently available key bindings:\r
+     (notmuch-show-move-to-message-top)\r
+     t))\r
+ \r
++(defun notmuch-show-mapc (function)\r
++  "Iterate through all messages with\r
++`notmuch-show-goto-message-next' and call `function' for side\r
++effects."\r
++  (save-excursion\r
++    (goto-char (point-min))\r
++    (loop do (funcall function)\r
++        while (notmuch-show-goto-message-next))))\r
++\r
+ ;; Functions relating to the visibility of messages and their\r
+ ;; components.\r
+ \r
+@@ -1222,6 +1231,18 @@ Some useful entries are:\r
+   "Return the message id of the current message."\r
+   (concat "id:\"" (notmuch-show-get-prop :id) "\""))\r
+ \r
++(defun notmuch-show-get-messages-ids ()\r
++  "Return all message ids of currently shown messages."\r
++  (let ((message-ids))\r
++    (notmuch-show-mapc\r
++     (lambda () (push (notmuch-show-get-message-id) message-ids)))\r
++    message-ids))\r
++\r
++(defun notmuch-show-get-messages-ids-search ()\r
++  "Return a search string for all message ids of currently shown\r
++messages."\r
++  (mapconcat 'identity (notmuch-show-get-messages-ids) " or "))\r
++\r
+ ;; dme: Would it make sense to use a macro for many of these?\r
+ \r
+ (defun notmuch-show-get-filename ()\r
+@@ -1496,7 +1517,7 @@ i.e. a list of tags to change with '+' and '-' prefixes."\r
+ `Changed-tags' is a list of tag operations for \"notmuch tag\",\r
+ i.e. a list of tags to change with '+' and '-' prefixes."\r
+   (interactive (notmuch-select-tags-with-completion nil notmuch-show-thread-id))\r
+-  (apply 'notmuch-tag notmuch-show-thread-id changed-tags)\r
++  (apply 'notmuch-tag (notmuch-show-get-messages-ids-search) changed-tags)\r
+   (save-excursion\r
+     (goto-char (point-min))\r
+     (loop do (let* ((current-tags (notmuch-show-get-tags))\r
+-- \r
+1.7.8.3\r
+\r