Make Package.metadata.defined_phases return all possible phases when

DEFINED_PHASES is undefined. This makes it easy to do containment
checks to see if it's safe to skip execution of a given phase.

diff --git a/pym/_emerge/Package.py b/pym/_emerge/Package.py
index 0a4f2ab7aaae183f7675ca8bdee9ff652d9f868a..d0b0e4918cda807a326b3cf751f75ad9878f2432 100644 (file)
--- a/pym/_emerge/Package.py
+++ b/pym/_emerge/Package.py
@@ -5,6 +5,7 @@ import sys
 from itertools import chain
 import portage
 from portage.cache.mappings import slot_dict_class
+from portage.const import EBUILD_PHASES
 from portage.dep import Atom, check_required_use, use_reduce, \
        paren_enclose, _slot_re
 from portage.eapi import eapi_has_iuse_defaults, eapi_has_required_use
@@ -490,4 +491,13 @@ class _PackageMetadataWrapper(_PackageMetadataWrapperBase):
 
        @property
        def defined_phases(self):
-               return self['DEFINED_PHASES'].split()
+               """
+               Returns tokens from DEFINED_PHASES metadata if it is defined,
+               otherwise returns a tuple containing all possible phases. This
+               makes it easy to do containment checks to see if it's safe to
+               skip execution of a given phase.
+               """
+               s = self['DEFINED_PHASES']
+               if s:
+                       return s.split()
+               return EBUILD_PHASES