Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when...

diff --git a/7a/464e61c661e7dd825deea6c2dcea517a39a097 b/7a/464e61c661e7dd825deea6c2dcea517a39a097
new file mode 100644 (file)
index 0000000..0eccc08
--- /dev/null
+++ b/7a/464e61c661e7dd825deea6c2dcea517a39a097
@@ -0,0 +1,119 @@
+Return-Path: <pieter@praet.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id DCFF840EC33\r
+       for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 05:48:51 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 1IxZovRTPapj for <notmuch@notmuchmail.org>;\r
+       Wed,  1 Feb 2012 05:48:51 -0800 (PST)\r
+Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com\r
+       [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id E5B9840EC2D\r
+       for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 05:48:50 -0800 (PST)\r
+Received: by wibhi8 with SMTP id hi8so971741wib.26\r
+       for <notmuch@notmuchmail.org>; Wed, 01 Feb 2012 05:48:49 -0800 (PST)\r
+Received: by 10.180.95.1 with SMTP id dg1mr41754746wib.21.1328104129672;\r
+       Wed, 01 Feb 2012 05:48:49 -0800 (PST)\r
+Received: from localhost ([109.131.39.11])\r
+       by mx.google.com with ESMTPS id dr5sm74056774wib.0.2012.02.01.05.48.49\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Wed, 01 Feb 2012 05:48:49 -0800 (PST)\r
+From: Pieter Praet <pieter@praet.org>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, David Bremner <david@tethera.net>,\r
+       David Edmondson <dme@dme.org>, Jani Nikula <jani@nikula.org>\r
+Subject: Re: [PATCH] emacs: globally replace non-branching "(if COND (progn\r
+       ..." with "(when ..."\r
+In-Reply-To: <m2zkd5ipsr.fsf@guru.guru-group.fi>\r
+References: <87k44uprvy.fsf@praet.org>\r
+       <1326532638-22068-1-git-send-email-pieter@praet.org>\r
+       <87y5ssxam7.fsf@zancas.localnet> <8739ax7jts.fsf@praet.org>\r
+       <m2zkd5ipsr.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.11+132~ga81001f (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+Date: Wed, 01 Feb 2012 14:46:53 +0100\r
+Message-ID: <871uqe7jjm.fsf@praet.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 01 Feb 2012 13:48:52 -0000\r
+\r
+On Mon, 30 Jan 2012 09:59:32 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> On Mon, 30 Jan 2012 08:03:59 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> > On Sat, 28 Jan 2012 08:41:36 -0400, David Bremner <david@tethera.net> wrote:\r
+> > > On Sat, 14 Jan 2012 10:17:18 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> > > > Less code, same results, without sacrificing readability.\r
+> > > > \r
+> > > \r
+> > > This looks OK, although the re-indenting makes these kind of changes\r
+> > > painful to review (not that I'm suggesting we should re-indent, just\r
+> > > some random complaining).\r
+> > > \r
+> > \r
+> > You can use `diff-refine-hunk' to see what the actual changes are.\r
+> > \r
+> > Try this:\r
+> > \r
+> >   #+begin_src emacs-lisp\r
+> >     (global-set-key (kbd "C-c /")\r
+> >                     (lambda()\r
+> >                       "Refine display of unified diff hunks"\r
+> >                       (interactive)\r
+> >                       (save-excursion\r
+> >                         (goto-char (point-min))\r
+> >                         (while (re-search-forward\r
+> >                                 diff-hunk-header-re-unified\r
+> >                                 nil t)\r
+> >                           (diff-refine-hunk)))))\r
+> >   #+end_src\r
+> > \r
+> > Work pretty much *anywhere*.\r
+> > \r
+> > Note: it does NOT work in `notmuch-show-mode' (not even with\r
+> > `notmuch-wash-convert-inline-patch-to-part' disabled), but this is\r
+> > easily solved by first running `notmuch-show-view-raw-message' ("V")\r
+> > and `diff-mode' (to fontify the buffer)...\r
+> \r
+> What we need is 'notmuch-devel' minor mode which can do this, dme's\r
+> notmuch patching tool, nmbug tag changes and everything...\r
+> \r
+\r
+Full ACK!\r
+\r
+\r
+> > \r
+> > > d\r
+> > \r
+> > \r
+> > Peace\r
+> > \r
+> > -- \r
+> > Pieter\r
+> \r
+> Tomi\r
+\r
+\r
+Peace\r
+\r
+-- \r
+Pieter\r