Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

diff --git a/5c/e3da925fb31dca0f96328a3806e72285ed0ec3 b/5c/e3da925fb31dca0f96328a3806e72285ed0ec3
new file mode 100644 (file)
index 0000000..f5dc073
--- /dev/null
+++ b/5c/e3da925fb31dca0f96328a3806e72285ed0ec3
@@ -0,0 +1,79 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8C1EA431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 27 Feb 2012 17:52:49 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id GPmYH9kJLO9b for <notmuch@notmuchmail.org>;\r
+       Mon, 27 Feb 2012 17:52:49 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 03C89431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 27 Feb 2012 17:52:48 -0800 (PST)\r
+Received: from fctnnbsc30w-142166230117.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([142.166.230.117] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)\r
+       (Exim 4.72) (envelope-from <bremner@unb.ca>)\r
+       id 1S2CF9-0004bY-Ks; Mon, 27 Feb 2012 21:52:45 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.77)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1S2CF4-0008O2-6T; Mon, 27 Feb 2012 21:52:38 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.\r
+In-Reply-To: <1327918561-16245-3-git-send-email-dme@dme.org>\r
+References: <1327496913-4946-1-git-send-email-dme@dme.org>\r
+       <1327918561-16245-1-git-send-email-dme@dme.org>\r
+       <1327918561-16245-3-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.11.1+240~g30b60bb (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 27 Feb 2012 21:52:38 -0400\r
+Message-ID: <8762eriv15.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Spam_bar: -\r
+Cc: =?utf-8?Q?Antoin?= =?utf-8?Q?e_Beaupr=C3=A9?= <anarcat@anarcat.ath.cx>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 28 Feb 2012 01:52:49 -0000\r
+\r
+On Mon, 30 Jan 2012 10:16:01 +0000, David Edmondson <dme@dme.org> wrote:\r
+> ---\r
+>  emacs/notmuch-lib.el   |    9 +++++++++\r
+>  emacs/notmuch-print.el |    8 ++++++--\r
+>  emacs/notmuch-show.el  |    5 ++++-\r
+>  emacs/notmuch.el       |   21 +++++++++------------\r
+>  4 files changed, 28 insertions(+), 15 deletions(-)\r
+\r
+Jameson and Antoine have asked for this patch to be reverted. As far as\r
+I understand it the printing code actually crashes on blank subjects if\r
+this patch is removed, so it seems to me that that (slightly) outweighs\r
+the annoyance caused by printing [No Subject].  I don't find the\r
+argument that different people are annoyed\r
+\r
+I'd be willing to be convinced otherwise, but as it turns out the\r
+question is somewhat academic; there have been enough changes that this\r
+patch no longer reverts cleanly. So Someone (TM) will have to do some to\r
+change the behaviour; it sounds like the sensible thing to do would be to move\r
+notmuch-prettify-subject into notmuch-print.el and call it there.\r
+\r
+d\r