Re: [PATCH 0/2] Bug and potential fix: forwarded messages

diff --git a/7d/08ec87544209a8bcf0d61c3010629c7371227d b/7d/08ec87544209a8bcf0d61c3010629c7371227d
new file mode 100644 (file)
index 0000000..514c09d
--- /dev/null
+++ b/7d/08ec87544209a8bcf0d61c3010629c7371227d
@@ -0,0 +1,121 @@
+Return-Path: <awg@xvx.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 39040431FAF\r
+       for <notmuch@notmuchmail.org>; Fri,  3 Feb 2012 22:01:26 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id umdDb1bX5NVx for <notmuch@notmuchmail.org>;\r
+       Fri,  3 Feb 2012 22:01:25 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 5AEA1431FAE\r
+       for <notmuch@notmuchmail.org>; Fri,  3 Feb 2012 22:01:25 -0800 (PST)\r
+Received: by bke11 with SMTP id 11so4092952bke.26\r
+       for <notmuch@notmuchmail.org>; Fri, 03 Feb 2012 22:01:24 -0800 (PST)\r
+MIME-Version: 1.0\r
+Received: by 10.204.145.82 with SMTP id c18mr4612994bkv.121.1328335283831;\r
+       Fri, 03 Feb 2012 22:01:23 -0800 (PST)\r
+Sender: awg@xvx.ca\r
+Received: by 10.204.104.13 with HTTP; Fri, 3 Feb 2012 22:01:23 -0800 (PST)\r
+X-Originating-IP: [96.52.216.56]\r
+In-Reply-To: <1328315554-16085-1-git-send-email-awg+notmuch@xvx.ca>\r
+References: <1328315554-16085-1-git-send-email-awg+notmuch@xvx.ca>\r
+Date: Fri, 3 Feb 2012 23:01:23 -0700\r
+X-Google-Sender-Auth: -g25LXHdD1HAOOLNHurAMVf0BhM\r
+Message-ID:\r
+ <CAMoJFUsfPwmLPxhK_mCbJ7N66u5+62QQne-oNJjVawSUzfFrjg@mail.gmail.com>\r
+Subject: Re: [PATCH 0/2] Bug and potential fix: forwarded messages\r
+From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>\r
+To: notmuch@notmuchmail.org\r
+Content-Type: text/plain; charset=ISO-8859-1\r
+Content-Transfer-Encoding: quoted-printable\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 04 Feb 2012 06:01:26 -0000\r
+\r
+Oh, and I just noticed that Dmitry has already fixed this, probably in\r
+a better way [1] (though I maintain that there still may be a problem\r
+with the approach in general).  I clearly haven't been following the\r
+list closely enough this week.\r
+\r
+[1] id:"1327926286-16680-1-git-send-email-dmitry.kurochkin@gmail.com"\r
+\r
+On Fri, Feb 3, 2012 at 17:32, Adam Wolfe Gordon <awg+notmuch@xvx.ca> wrote:\r
+> Hi everyone,\r
+>\r
+> I encountered today a bug that I remember being mentioned on IRC where\r
+> some messages are shown in emacs as completely empty, even though their\r
+> content is present and simple. For me, the bug shows up with messages tha=\r
+t\r
+> have been forwarded by an Outlook user who didn't add any content to the =\r
+top\r
+> of the message. The first line of the message is "-----Original Message--=\r
+---",\r
+> and the rest is the forwarded text. Notmuch tries to collapse the forward=\r
+ed\r
+> content into a button, but fails mysteriously.\r
+>\r
+> The first patch in this series adds a test (marked as broken) that demons=\r
+trates\r
+> the bug. I think this should be pushed regardless of whether my solution =\r
+is\r
+> the right one. My solution is to check whether we're collapsing the entir=\r
+e\r
+> message before doing so, and avoid turning it into a button if that's the=\r
+ case.\r
+> I think this is a desirable behavior, since if someone has forwarded a me=\r
+ssage\r
+> without adding anything the user probably wants to read that message. But=\r
+,\r
+> I'll admit that I didn't figure out the real cause of the problem, and I\r
+> would be happy to hear other suggestions.\r
+>\r
+> It also occurs to me that this might indicate a bigger problem with how\r
+> notmuch-wash.el handles messages starting with "-----Original Message----=\r
+-".\r
+> Notmuch seems to assume that this indicates the rest of the message is qu=\r
+oted\r
+> stuff that's been top-posted on. In my office this isn't necessarily the =\r
+case,\r
+> since Outlook produces that line at the top of every reply, and it's up t=\r
+o\r
+> the user whether to top-post or not (and not everyone does).\r
+>\r
+> I'll have to experiment a bit more to verify whether a problem (i.e. whet=\r
+her\r
+> Notmuch hides inappropriate things when someone replies inline with Outlo=\r
+ok).\r
+> Someone please correct me if I'm missing something in how the code operat=\r
+es.\r
+>\r
+> Adam Wolfe Gordon (2):\r
+> =A0test: Add broken test for showing forwarded messages\r
+> =A0emacs: Fix broken showing of forwarded messages.\r
+>\r
+> =A0emacs/notmuch-wash.el | =A0 =A05 +++--\r
+> =A0test/emacs =A0 =A0 =A0 =A0 =A0 =A0| =A0 32 +++++++++++++++++++++++++++=\r
++++++\r
+> =A02 files changed, 35 insertions(+), 2 deletions(-)\r
+>\r
+> --\r
+> 1.7.5.4\r
+>\r