Re: [PATCH v2 3/8] show: Allow formatters to return errors

diff --git a/c9/bb43372f61a5b2509323d7ea1892d05d760873 b/c9/bb43372f61a5b2509323d7ea1892d05d760873
new file mode 100644 (file)
index 0000000..b61b7c2
--- /dev/null
+++ b/c9/bb43372f61a5b2509323d7ea1892d05d760873
@@ -0,0 +1,84 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 23DB7431FB6\r
+       for <notmuch@notmuchmail.org>; Wed,  7 Mar 2012 12:18:14 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 73CtQ2ieBxKe for <notmuch@notmuchmail.org>;\r
+       Wed,  7 Mar 2012 12:18:13 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1F821431FAE\r
+       for <notmuch@notmuchmail.org>; Wed,  7 Mar 2012 12:18:13 -0800 (PST)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 4605D68055; Wed,  7 Mar 2012 22:18:11 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>,\r
+       Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 3/8] show: Allow formatters to return errors\r
+In-Reply-To: <87ipihbf0w.fsf@qmul.ac.uk>\r
+References: <1330752025-2542-1-git-send-email-amdragon@mit.edu>\r
+       <1331059724-14653-1-git-send-email-amdragon@mit.edu>\r
+       <1331059724-14653-4-git-send-email-amdragon@mit.edu>\r
+       <87ipihbf0w.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.11.1+288~g4b3af0e (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 07 Mar 2012 22:18:11 +0200\r
+Message-ID: <m2y5rc6u7w.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 07 Mar 2012 20:18:14 -0000\r
+\r
+On Tue, 06 Mar 2012 21:22:55 +0000, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> On Tue,  6 Mar 2012 18:48:39 +0000, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> > Formatter errors are propagated to the exit status of notmuch show.\r
+> > \r
+> > This isn't used by the JSON or text formatters, but it will be useful\r
+> > for the raw format, which is pickier.\r
+> \r
+> I am not very familiar with this part of the code but the whole series\r
+> looks fine to me.\r
+\r
+Looks good to me too.\r
+\r
+> \r
+> My only minor comment is that I like Tom's suggestion (in\r
+> id:"m2399qrtat.fsf@guru.guru-group.fi") of having NOTMUCH_STATUS_FAILURE\r
+> (= 1) to make the error handling look cleaner. Alternatively (or\r
+> possibly as well) the functions do_show and do_show_messages could pass\r
+> the actual error back up to notmuch_show_command and then that function\r
+> could convert return 0/1 as appropriate.\r
+> \r
+> As usual I am quite happy to be overruled!\r
+\r
+As usual I no longer know why I suggested that in the first place\r
+(at least in the context of these patches ;D)\r
+\r
+> Best wishes\r
+> \r
+> Mark\r
+\r
+Tomi\r
+\r