Re: [PATCH 1/7] Split notmuch_database_close into two functions

diff --git a/24/d3c0ba8fee1956667a6768835393bdc870d78d b/24/d3c0ba8fee1956667a6768835393bdc870d78d
new file mode 100644 (file)
index 0000000..f91845c
--- /dev/null
+++ b/24/d3c0ba8fee1956667a6768835393bdc870d78d
@@ -0,0 +1,95 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 42759431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 25 Apr 2012 06:35:04 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id nqG3oMKmEGR5 for <notmuch@notmuchmail.org>;\r
+       Wed, 25 Apr 2012 06:35:02 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU\r
+       [18.9.25.14])\r
+       by olra.theworths.org (Postfix) with ESMTP id C22C0431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 25 Apr 2012 06:35:02 -0700 (PDT)\r
+X-AuditID: 1209190e-b7f7c6d0000008c3-5a-4f97fd859577\r
+Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
+       by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 61.79.02243.58DF79F4; Wed, 25 Apr 2012 09:35:01 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q3PDZ0W9032751; \r
+       Wed, 25 Apr 2012 09:35:00 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q3PDYvBh007920\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Wed, 25 Apr 2012 09:34:59 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1SN2Mz-0001e4-Nx; Wed, 25 Apr 2012 09:34:57 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/7] Split notmuch_database_close into two functions\r
+In-Reply-To:\r
+ <1335360016-20289-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+References: <20120422180159.GG17810@mit.edu>\r
+       <1335360016-20289-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+User-Agent: Notmuch/0.12+132~gf2f390b (http://notmuchmail.org) Emacs/23.3.1\r
+       (i486-pc-linux-gnu)\r
+Date: Wed, 25 Apr 2012 09:34:57 -0400\r
+Message-ID: <87r4vcgcji.fsf@awakening.csail.mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFnrIIsWRmVeSWpSXmKPExsUixG6notv6d7q/wfwueYvZrT+YLK7fnMns\r
+       wOQx8fxpNo9nq24xBzBFcdmkpOZklqUW6dslcGWcbf3EXPCXtWLtjY9MDYz/WboYOTkkBEwk\r
+       3px9zQhhi0lcuLeerYuRi0NIYB+jxPf+NVDOBkaJbfu/M0E4J5kkfl9qYoFwljBKLJu7lw2k\r
+       n01AA6hqOdgsEQE/iVcP5zCB2MICHhI7ru0Bi3MKBEnMOfMFzBYSKJKYvvoemC0qEC/xp3cz\r
+       0BwODhYBVYmVqwJAwrxA5x3ZsIsFwhaUODnzCZjNLKAlcePfS6YJjAKzkKRmIUktYGRaxSib\r
+       klulm5uYmVOcmqxbnJyYl5dapGusl5tZopeaUrqJERSSnJJ8Oxi/HlQ6xCjAwajEwzt77zR/\r
+       IdbEsuLK3EOMkhxMSqK8h39N9xfiS8pPqcxILM6ILyrNSS0+xCjBwawkwvviJVCONyWxsiq1\r
+       KB8mJc3BoiTOq6b1zk9IID2xJDU7NbUgtQgmK8PBoSTByw8yVLAoNT21Ii0zpwQhzcTBCTKc\r
+       B2j4UpAa3uKCxNzizHSI/ClGRSlx3pKfQAkBkERGaR5cLyxlvGIUB3pFmNcOpIoHmG7gul8B\r
+       DWYCGvwtaBrI4JJEhJRUA+OqIF72+Xu+vHnO/GUq+7UepfMX1dvDzZaZidn1R7bODF21dKXS\r
+       J/9zbEy7hRWvbYxsXLY32XsSc5iWRr7naY3yxqUlHX07niw2PL/pBUfysgO3nHb1a0ZFVXoK\r
+       BpwMvzrd/1+9hrKTxd20qXEZiS+z5iVdqPp8IehNhGTt1HmXNz+v93JndlZiKc5INNRiLipO\r
+       BADU44xF9AIAAA==\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 25 Apr 2012 13:35:04 -0000\r
+\r
+LGTM.\r
+\r
+On Wed, 25 Apr 2012, Justus Winter <4winter@informatik.uni-hamburg.de> wrote:\r
+> Formerly notmuch_database_close closed the xapian database and\r
+> destroyed the talloc structure associated with the notmuch database\r
+> object. Split notmuch_database_close into notmuch_database_close and\r
+> notmuch_database_destroy.\r
+>\r
+> This makes it possible for long running programs to close the xapian\r
+> database and thus release the lock associated with it without\r
+> destroying the data structures obtained from it.\r
+>\r
+> This also makes the api more consistent since every other data\r
+> structure has a destructor function.\r
+>\r
+> The comments in notmuch.h are a courtesy of Austin Clements.\r
+>\r
+> Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>\r