Re: [PATCH] emacs: Fix "not defined at runtime" warning

diff --git a/c0/5ce16800532767a791c604cfffb420c9daeefc b/c0/5ce16800532767a791c604cfffb420c9daeefc
new file mode 100644 (file)
index 0000000..4a49912
--- /dev/null
+++ b/c0/5ce16800532767a791c604cfffb420c9daeefc
@@ -0,0 +1,113 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4C252431FAF\r
+       for <notmuch@notmuchmail.org>; Thu,  9 Aug 2012 00:55:04 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 3VwNPTi3SDBp for <notmuch@notmuchmail.org>;\r
+       Thu,  9 Aug 2012 00:55:03 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id C88F5431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  9 Aug 2012 00:55:03 -0700 (PDT)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by earth-doxen-postvirus (Postfix) with ESMTP id 60EC766E0123;\r
+       Thu,  9 Aug 2012 00:55:01 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (unknown [76.89.192.57])\r
+       (Authenticated sender: jrollins)\r
+       by earth-doxen-submit (Postfix) with ESMTP id 4C8E666E0121;\r
+       Thu,  9 Aug 2012 00:54:58 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id DD46A73E; Thu,  9 Aug 2012 00:54:57 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Fix "not defined at runtime" warning\r
+In-Reply-To: <1344462010-5349-1-git-send-email-amdragon@mit.edu>\r
+References: <1344462010-5349-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.13.2+137~ge34ed71 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 09 Aug 2012 00:54:55 -0700\r
+Message-ID: <87628sa4a8.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 09 Aug 2012 07:55:04 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Wed, Aug 08 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> Previously, the Emacs byte compiler produced the warning\r
+>\r
+>     the function `remove-if-not' might not be defined at runtime.\r
+>\r
+> because we only required cl at compile-time (not runtime).  This fixes\r
+> this warning by requiring cl at runtime, ensuring that the definition\r
+> of remove-if-not is available.\r
+> ---\r
+>  emacs/notmuch-lib.el |    2 +-\r
+>  1 file changed, 1 insertion(+), 1 deletion(-)\r
+>\r
+> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el\r
+> index 30db58f..900235b 100644\r
+> --- a/emacs/notmuch-lib.el\r
+> +++ b/emacs/notmuch-lib.el\r
+> @@ -24,7 +24,7 @@\r
+>  (require 'mm-view)\r
+>  (require 'mm-decode)\r
+>  (require 'json)\r
+> -(eval-when-compile (require 'cl))\r
+> +(require 'cl)\r
+>=20=20\r
+>  (defvar notmuch-command "notmuch"\r
+>    "Command to run the notmuch binary.")\r
+\r
+LGTM.  I think it would be good to finally just give in a require cl, so\r
+we can finally put to rest the long standing schizophrenia we've had in\r
+regards to using it, and maybe finally kill the compile warnings that\r
+keep popping up.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.12 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJQI2zPAAoJEO00zqvie6q8WvsP/03xPiW6ed/n232244uU5LkZ\r
+K1+N0Iz7VvcwCp/3IL/gbYW7iQTg0hxLcfcRIBzVvY/eHM6ejB7FQjzzUSLqBL49\r
+qzepIvXuxC+EbIi5gINhNh51ATbV26243d09a+ulVyO7sBjyqUNA5yGCworjyLBX\r
+a5uE2cLZe6LbcbVTooXiZqOLo5o0rvzxJoxCCfk4qCm1v5DYnl7kkKa6zmqdESrx\r
+3vb+sVoU+VBVjIdeCmw6PzYXlM/Aq0MfWuNOxkk9XxNEDuJJeKHGJK99/A7yL/vP\r
+gsgxwionPySlpT2Kg7lx5VHNUP9tIAR/O2CWkxF937ku4j1PuT/tUl/LNjaqp8py\r
+Y7Td/KEGwaY41MxoWV8LiKFOghrkYCwwp2bc0LqzJbzGidpD56I0FAGZkKtkISsh\r
+T6lEYAk5V1yHMptkutNB7moVD/xGa8GO4V8wsE9EjNMoFtZZ9BZLQXszH//U2A2K\r
+7YMWF9+Ora94D5Tj09c//S8LLCnjWOLJRCm7N4Re4VLioZI43eW+98P19fvABQSQ\r
+7G0NjZygBnjwUrwOGxXRpQsEcDzg8OxFqGX/adC+Wx26EdA2supvRorK5k0lejRp\r
+IJ18fwBH/AZ8kE+sEcKN+OX91qGWro49ISF5aAdNgAoHW/xD0yqjpYjcDlG8O88e\r
+u/CAoEDeVFtUwUu9VLXh\r
+=ZVfl\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r