Re: [PATCH 08/10] notmuch-config: header for index() prototype (Solaris support)

diff --git a/67/cf4850bec36b5a5deba864d61b6c865acecfc3 b/67/cf4850bec36b5a5deba864d61b6c865acecfc3
new file mode 100644 (file)
index 0000000..520d8dc
--- /dev/null
+++ b/67/cf4850bec36b5a5deba864d61b6c865acecfc3
@@ -0,0 +1,65 @@
+Return-Path: <blakej@foo.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B911C431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  4 Nov 2012 20:53:07 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id rpZvVxgz907H for <notmuch@notmuchmail.org>;\r
+       Sun,  4 Nov 2012 20:53:07 -0800 (PST)\r
+Received: from foo.net (70-36-235-136.dsl.static.sonic.net [70.36.235.136])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 31100431FAE\r
+       for <notmuch@notmuchmail.org>; Sun,  4 Nov 2012 20:53:07 -0800 (PST)\r
+Received: from foo.net (localhost [127.0.0.1])\r
+       by foo.net (8.14.5+Sun/8.14.5) with ESMTP id qA54qxmv004983;\r
+       Sun, 4 Nov 2012 20:52:59 -0800 (PST)\r
+To: Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH 08/10] notmuch-config: header for index() prototype\r
+       (Solaris support) \r
+In-Reply-To: Your message of "Sun, 04 Nov 2012 23:47:15 +0200."\r
+       <m2pq3tniqk.fsf@guru.guru-group.fi> \r
+Date: Sun, 04 Nov 2012 20:52:59 -0800\r
+Message-ID: <4982.1352091179@foo.net>\r
+From: Blake Jones <blakej@foo.net>\r
+X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2\r
+       (foo.net [127.0.0.1]); Sun, 04 Nov 2012 20:52:59 -0800 (PST)\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 05 Nov 2012 04:53:07 -0000\r
+\r
+>> On Sun, 04 Nov 2012, Blake Jones <blakej@foo.net> wrote:\r
+>>> Linux, FreeBSD, and Solaris all expect to find the prototype for\r
+>>> "index()" in <strings.h>.  On some operating systems, including\r
+>>> <string.h> is sufficient to get the prototype, but that's not the case\r
+>>> on Solaris.  This patch just modifies notmuch-config.c to include\r
+>>> <strings.h> to get the prototype.\r
+>>\r
+>> We should probably just nuke index() and use strchr() instead.\r
+> \r
+> indeed!\r
+\r
+That was my initial preference, but I didn't know if there was anyone\r
+who was committed to the BSD name.  Given that two more people think\r
+it's a good idea, I'll do that instead.\r
+\r
+Blake\r