Re: [PATCH 2/5] go: Update for changes to notmuch_database_get_directory

diff --git a/e9/65c83734dc711e3dd7ea6bf4ea0e559837e961 b/e9/65c83734dc711e3dd7ea6bf4ea0e559837e961
new file mode 100644 (file)
index 0000000..ff1d8ce
--- /dev/null
+++ b/e9/65c83734dc711e3dd7ea6bf4ea0e559837e961
@@ -0,0 +1,108 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 03E2C431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 13 May 2012 16:15:18 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id aldJS7O-BgTW for <notmuch@notmuchmail.org>;\r
+       Sun, 13 May 2012 16:15:17 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU\r
+       [18.7.68.35])\r
+       by olra.theworths.org (Postfix) with ESMTP id 74FF2431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 13 May 2012 16:15:17 -0700 (PDT)\r
+X-AuditID: 12074423-b7fcc6d0000008a8-ba-4fb04084be8f\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 11.A8.02216.48040BF4; Sun, 13 May 2012 19:15:16 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q4DNFFd9024220; \r
+       Sun, 13 May 2012 19:15:15 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q4DNFDdr028317\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Sun, 13 May 2012 19:15:13 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1STi0O-0005Va-UH; Sun, 13 May 2012 19:15:12 -0400\r
+Date: Sun, 13 May 2012 19:15:12 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+Subject: Re: [PATCH 2/5] go: Update for changes to\r
+       notmuch_database_get_directory\r
+Message-ID: <20120513231512.GN11804@mit.edu>\r
+References: <1336939029-13969-1-git-send-email-amdragon@mit.edu>\r
+       <1336939029-13969-3-git-send-email-amdragon@mit.edu>\r
+       <20120513215135.15106.40581@thinkbox.jade-hamburg.de>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <20120513215135.15106.40581@thinkbox.jade-hamburg.de>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFprHKsWRmVeSWpSXmKPExsUixCmqrNvisMHf4PFmG4vZrT+YLG60djNa\r
+       NE13trh+cyazxZuV81gdWD0Of13I4jHx/Gk2j1v3X7N7PFt1i9ljy6H3zAGsUVw2Kak5mWWp\r
+       Rfp2CVwZM+ZtYC44yF7xbhlrA2MDWxcjJ4eEgInEnyVHmSBsMYkL99YDxbk4hAT2MUrsaZ3A\r
+       BOFsYJRo7F3IDOGcZJL4PXEmlLOEUaJ5wWNWkH4WAVWJ90c2gs1lE9CQ2LZ/OSOILSJgKrHh\r
+       wQN2EJtZIEZizdqbQGM5OIQFgiW2XnYDMXkFdCQWrpUFqRASWM8osWyzLojNKyAocXLmExaI\r
+       Ti2JG/9egnUyC0hLLP/HARLmFHCSOP5iHtgBogIqElNObmObwCg0C0n3LCTdsxC6FzAyr2KU\r
+       Tcmt0s1NzMwpTk3WLU5OzMtLLdI108vNLNFLTSndxAiKBnYX5R2Mfw4qHWIU4GBU4uF9abrB\r
+       X4g1say4MvcQoyQHk5Io7047oBBfUn5KZUZicUZ8UWlOavEhRgkOZiUR3vUP1/sL8aYkVlal\r
+       FuXDpKQ5WJTEeTW03vkJCaQnlqRmp6YWpBbBZGU4OJQkeLfaAw0VLEpNT61Iy8wpQUgzcXCC\r
+       DOcBGq4DUsNbXJCYW5yZDpE/xagoJc67GiQhAJLIKM2D64Ulq1eM4kCvCPP2gVTxABMdXPcr\r
+       oMFMQIP5BdaBDC5JREhJNTDGhJ/3LG0Rt9GVXpvyy3rn6wsSG96buxqGffBf4Dtvm4e64fUP\r
+       uZ6sQlv1d6+O2JN5TpztfPSqFm6Z9E2/apidTDhm7vdsiwnYv0NOruCm0VnGaJc0mbX7Fq1e\r
+       EOT34sj7vmhL8TWGzxeu6LWdIF6UcPC0+OmFkdLVB9zTZasaC4RvLxXymanEUpyRaKjFXFSc\r
+       CADVecN0MQMAAA==\r
+Cc: tomi.ollila@iki.fi, notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 13 May 2012 23:15:18 -0000\r
+\r
+Quoth Justus Winter on May 13 at 11:51 pm:\r
+> Hi Austin,\r
+> \r
+> thanks for taking care of this.\r
+> \r
+> Quoting Austin Clements (2012-05-13 21:57:06)\r
+> > ---\r
+> >  bindings/go/src/notmuch/notmuch.go  |   13 +++++++------\r
+> >  bindings/python/notmuch/database.py |    4 ++--\r
+> \r
+> A change to the python bindings slipped into this one.\r
+\r
+Sure enough.  I'll send a v2 that moves that hunk to the python patch.\r
+\r
+> Other than that this looks good.\r
+> \r
+> I just saw that I marked another function as problematic,\r
+> notmuch_database_find_message_by_filename ends up calling\r
+> _notmuch_directory_create that aborts if the database is not\r
+> writable. But this might have to wait and might not even requira an\r
+> api change.\r
+\r
+Right.  notmuch_database_find_message_by_filename already has a status\r
+return, so its API is fine.  (Actually, I was starting to fix its\r
+implementation when I realized notmuch_database_get_directory was\r
+problematic.)\r
+\r
+> Justus\r