media-plugins/audacious-plugins: Modernise src_configure
authorAndreas Sturmlechner <asturm@gentoo.org>
Mon, 19 Nov 2018 22:32:37 +0000 (23:32 +0100)
committerAndreas Sturmlechner <asturm@gentoo.org>
Mon, 19 Nov 2018 22:47:54 +0000 (23:47 +0100)
Use myeconfargs array.

Package-Manager: Portage-2.3.52, Repoman-2.3.12
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
media-plugins/audacious-plugins/audacious-plugins-3.10.ebuild
media-plugins/audacious-plugins/audacious-plugins-9999.ebuild

index 6cbc7f321652c94155684bd7af71416e1bf5e799..01c53d0961d170719578be2640b1822748fb12ad 100644 (file)
@@ -103,51 +103,51 @@ PATCHES=( "${FILESDIR}/${P}-fix-slow-search.patch" )
 S="${WORKDIR}/${MY_P}"
 
 src_configure() {
-       if ! use mp3 ; then
-               ewarn "MP3 support is optional, you may want to enable the mp3 USE-flag"
-       fi
+       use mp3 || ewarn "MP3 support is optional, you may want to enable the mp3 USE-flag"
 
-       econf \
-               --enable-mpris2 \
-               --enable-qt \
-               --enable-songchange \
-               --disable-aosd \
-               --disable-coreaudio \
-               --disable-gtk \
-               --disable-hotkey \
-               --disable-notify \
-               --disable-oss4 \
-               --disable-qtglspectrum \
-               --disable-sndio \
-               $(use_enable aac) \
-               $(use_enable alsa) \
-               $(use_enable ampache) \
-               $(use_enable bs2b) \
-               $(use_enable cdda cdaudio) \
-               $(use_enable cue) \
-               $(use_enable flac) \
-               $(use_enable flac filewriter) \
-               $(use_enable fluidsynth amidiplug) \
-               $(use_enable gme console) \
-               $(use_enable http neon) \
-               $(use_enable jack) \
-               $(use_enable lame filewriter_mp3) \
-               $(use_enable libnotify notify) \
-               $(use_enable libsamplerate resample) \
-               $(use_enable lirc) \
-               $(use_enable mms) \
-               $(use_enable modplug) \
-               $(use_enable mp3 mpg123) \
-               $(use_enable nls) \
-               $(use_enable pulseaudio pulse) \
-               $(use_enable qtmedia qtaudio) \
-               $(use_enable scrobbler scrobbler2) \
-               $(use_enable sdl sdlout) \
-               $(use_enable sid) \
-               $(use_enable sndfile) \
-               $(use_enable soxr) \
-               $(use_enable speedpitch) \
-               $(use_enable vorbis) \
-               $(use_enable wavpack) \
+       local myeconfargs=(
+               --enable-mpris2
+               --enable-qt
+               --enable-songchange
+               --disable-aosd
+               --disable-coreaudio
+               --disable-gtk
+               --disable-hotkey
+               --disable-notify
+               --disable-oss4
+               --disable-qtglspectrum
+               --disable-sndio
+               $(use_enable aac)
+               $(use_enable alsa)
+               $(use_enable ampache)
+               $(use_enable bs2b)
+               $(use_enable cdda cdaudio)
+               $(use_enable cue)
+               $(use_enable flac)
+               $(use_enable flac filewriter)
+               $(use_enable fluidsynth amidiplug)
+               $(use_enable gme console)
+               $(use_enable http neon)
+               $(use_enable jack)
+               $(use_enable lame filewriter_mp3)
+               $(use_enable libnotify notify)
+               $(use_enable libsamplerate resample)
+               $(use_enable lirc)
+               $(use_enable mms)
+               $(use_enable modplug)
+               $(use_enable mp3 mpg123)
+               $(use_enable nls)
+               $(use_enable pulseaudio pulse)
+               $(use_enable qtmedia qtaudio)
+               $(use_enable scrobbler scrobbler2)
+               $(use_enable sdl sdlout)
+               $(use_enable sid)
+               $(use_enable sndfile)
+               $(use_enable soxr)
+               $(use_enable speedpitch)
+               $(use_enable vorbis)
+               $(use_enable wavpack)
                $(use_with ffmpeg ffmpeg $(usex libav libav ffmpeg))
+       )
+       econf "${myeconfargs[@]}"
 }
index 944bc654f1d9852315ba3aebd2b95c5c124b0eb2..bcc581ce8a057cd66ebe8fa1a958c72f1a1c886a 100644 (file)
@@ -117,50 +117,50 @@ src_prepare() {
 }
 
 src_configure() {
-       if ! use mp3 ; then
-               ewarn "MP3 support is optional, you may want to enable the mp3 USE-flag"
-       fi
+       use mp3 || ewarn "MP3 support is optional, you may want to enable the mp3 USE-flag"
 
-       econf \
-               --enable-mpris2 \
-               --enable-songchange \
-               --disable-oss4 \
-               --disable-qtglspectrum \
-               --disable-coreaudio \
-               --disable-sndio \
-               $(use_enable aac) \
-               $(use_enable alsa) \
-               $(use_enable ampache) \
-               $(use_enable aosd) \
-               $(use_enable bs2b) \
-               $(use_enable cdda cdaudio) \
-               $(use_enable cue) \
-               $(use_enable flac) \
-               $(use_enable flac filewriter) \
-               $(use_enable fluidsynth amidiplug) \
-               $(use_enable gme console) \
-               $(use_enable gtk) \
-               $(use_enable hotkeys hotkey) \
-               $(use_enable http neon) \
-               $(use_enable jack) \
-               $(use_enable lame filewriter_mp3) \
-               $(use_enable libnotify notify) \
-               $(use_enable libsamplerate resample) \
-               $(use_enable lirc) \
-               $(use_enable mms) \
-               $(use_enable modplug) \
-               $(use_enable mp3 mpg123) \
-               $(use_enable nls) \
-               $(use_enable pulseaudio pulse) \
-               $(use_enable qt5 qt) \
-               $(use_enable qtmedia qtaudio) \
-               $(use_enable scrobbler scrobbler2) \
-               $(use_enable sdl sdlout) \
-               $(use_enable sid) \
-               $(use_enable sndfile) \
-               $(use_enable soxr) \
-               $(use_enable speedpitch) \
-               $(use_enable vorbis) \
-               $(use_enable wavpack) \
+       local myeconfargs=(
+               --enable-mpris2
+               --enable-songchange
+               --disable-oss4
+               --disable-qtglspectrum
+               --disable-coreaudio
+               --disable-sndio
+               $(use_enable aac)
+               $(use_enable alsa)
+               $(use_enable ampache)
+               $(use_enable aosd)
+               $(use_enable bs2b)
+               $(use_enable cdda cdaudio)
+               $(use_enable cue)
+               $(use_enable flac)
+               $(use_enable flac filewriter)
+               $(use_enable fluidsynth amidiplug)
+               $(use_enable gme console)
+               $(use_enable gtk)
+               $(use_enable hotkeys hotkey)
+               $(use_enable http neon)
+               $(use_enable jack)
+               $(use_enable lame filewriter_mp3)
+               $(use_enable libnotify notify)
+               $(use_enable libsamplerate resample)
+               $(use_enable lirc)
+               $(use_enable mms)
+               $(use_enable modplug)
+               $(use_enable mp3 mpg123)
+               $(use_enable nls)
+               $(use_enable pulseaudio pulse)
+               $(use_enable qt5 qt)
+               $(use_enable qtmedia qtaudio)
+               $(use_enable scrobbler scrobbler2)
+               $(use_enable sdl sdlout)
+               $(use_enable sid)
+               $(use_enable sndfile)
+               $(use_enable soxr)
+               $(use_enable speedpitch)
+               $(use_enable vorbis)
+               $(use_enable wavpack)
                $(use_with ffmpeg ffmpeg $(usex libav libav ffmpeg))
+       )
+       econf "${myeconfargs[@]}"
 }