Merged from trunk 7353:7371

   Merged from trunk 7353:7371

   +------------------------------------------------------------------------+
   | 7354      | Run pychecker over everything, fix obvious thing slike     |
   | WarnerBro | modules not in use, variables not being used, or global    |
   |           | exceptions not being deleted. Also fix imports for style   |
   |           | (1 per line)                                               |
   |-----------+------------------------------------------------------------|
   | 7355      | remove unused vars from xpak, fix bug in compose. Also fix |
   | WarnerBro | tests for portage sets, fix misnamed variable.             |
   |-----------+------------------------------------------------------------|
   | 7356      | Add notes about import statements (clarity) and fix        |
   | WarnerBro | spelling error in release-notes                            |
   |-----------+------------------------------------------------------------|
   | 7357      | Fix spacing issues, imports                                |
   | WarnerBro |                                                            |
   |-----------+------------------------------------------------------------|
   | 7358      | For bug #184774, put lha's -q option last since otherwise  |
   | zmedico   | the option parser now requires level 0, 1, or 2 to be      |
   |           | specified.                                                 |
   |-----------+------------------------------------------------------------|
   | 7360      | add test for CommandOutputSet                              |
   | WarnerBro |                                                            |
   |-----------+------------------------------------------------------------|
   | 7361      | add docstring, fix up imports (style), add keyword         |
   | WarnerBro | expansion                                                  |
   |-----------+------------------------------------------------------------|
   | 7362      | fix missing import, default value for value in case we try |
   | WarnerBro | to .join on a variable that hasn't been assigned to yet    |
   |-----------+------------------------------------------------------------|
   | 7363      | Fix hardcoded /usr/bin/echo to use                         |
   | zmedico   | portage.process.find_binary().                             |
   |-----------+------------------------------------------------------------|
   | 7364      | fix spacing, comments, default args                        |
   | WarnerBro |                                                            |
   |-----------+------------------------------------------------------------|
   | 7365      | Move common file functionality into a FileLoader class and |
   | WarnerBro | delegate parsing to subclasses via a lineParser func, no   |
   |           | idea how this will work performance wise. Fix errors in    |
   |           | parser (blank lines are not errors ;))                     |
   |-----------+------------------------------------------------------------|
   | 7366      | Move classes out of __init__.py, they do not belong there. |
   | WarnerBro | Fix import style, and import statements broken by class    |
   |           | moves.                                                     |
   |-----------+------------------------------------------------------------|
   | 7367      | Fix imports for style, deprecate grab*, what is            |
   | WarnerBro | foo.metadata and what does it contain                      |
   |-----------+------------------------------------------------------------|
   | 7368      | Validator should be a function, not a class, fix           |
   | WarnerBro | spacing/tab issues. Fix parsing errors for                 |
   |           | KeyValuePairLoader. Add a GenericFileLoader class that     |
   |           | uses more than 1 loader in a vain attempt to figure out    |
   |           | what kind of file it is. Fix inheritance by renaming       |
   |           | UserConfigKlass                                            |
   |-----------+------------------------------------------------------------|
   | 7369      | Fix imports for style, slight optimization for grab*       |
   | WarnerBro | function, doc fixups.                                      |
   |-----------+------------------------------------------------------------|
   | 7370      | fix broken import                                          |
   | WarnerBro |                                                            |
   |-----------+------------------------------------------------------------|
   | 7371      | add more tests for keyvaluepairloader (it had a bug        |
   | WarnerBro | previously) and fix up other misc tests                    |
   +------------------------------------------------------------------------+

svn path=/main/branches/prefix/; revision=7372