From 1ba97b96c82753464d0c52a040b49f8eefc4941c Mon Sep 17 00:00:00 2001 From: "W. Trevor King" Date: Fri, 8 Mar 2013 10:57:20 -0500 Subject: [PATCH] swc-installation-test-2.py: Don't override Popen's 'close_fds' Or 'shell'. The support for these options can be flaky, and the defaults change with Python version depending on what is best supported [1]. [1]: http://docs.python.org/2/library/subprocess.html#subprocess.Popen Reported-by: Ethan White --- setup/swc-installation-test-2.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup/swc-installation-test-2.py b/setup/swc-installation-test-2.py index 89d6d46..6da7ce7 100755 --- a/setup/swc-installation-test-2.py +++ b/setup/swc-installation-test-2.py @@ -416,7 +416,7 @@ class CommandDependency (Dependency): p = _subprocess.Popen( [command] + list(self.version_options), stdin=popen_stdin, stdout=_subprocess.PIPE, stderr=_subprocess.PIPE, - close_fds=True, shell=False, universal_newlines=True) + universal_newlines=True) except OSError as e: raise DependencyError( checker=self, -- 2.26.2