From d6e610be52a91dbb1213afa9c68d832d21e02c58 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Thu, 8 Sep 2011 08:49:10 +0100 Subject: [PATCH] Re: RFC/PATCH emacs attachment handling --- 76/c863a846cbf768a1c8bdff4b538581e52a709b | 85 +++++++++++++++++++++++ 1 file changed, 85 insertions(+) create mode 100644 76/c863a846cbf768a1c8bdff4b538581e52a709b diff --git a/76/c863a846cbf768a1c8bdff4b538581e52a709b b/76/c863a846cbf768a1c8bdff4b538581e52a709b new file mode 100644 index 000000000..a67eb4fc4 --- /dev/null +++ b/76/c863a846cbf768a1c8bdff4b538581e52a709b @@ -0,0 +1,85 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4F50F431FD0 + for ; Thu, 8 Sep 2011 00:49:14 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 1.424 +X-Spam-Level: * +X-Spam-Status: No, score=1.424 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=2.223, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id O8eeV1DnUq9y for ; + Thu, 8 Sep 2011 00:49:14 -0700 (PDT) +Received: from mail-gw0-f43.google.com (mail-gw0-f43.google.com + [74.125.83.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + D9026431FB6 for ; Thu, 8 Sep 2011 00:49:13 -0700 + (PDT) +Received: by gwm11 with SMTP id 11so556934gwm.2 + for ; Thu, 08 Sep 2011 00:49:11 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; + h=mime-version:in-reply-to:references:date:message-id:subject:from:to + :cc:content-type; + bh=/VMP1zHl5gFYNuyVVX9CCQnq8QTCNf3L4fFmUjJzVc4=; + b=ScEod8of6AO7xVEzr3twJ1if6HzXsb59ZpJuvgKi0RwNUkNsbjGK5oHBc33XBsEqj6 + rBZaxKm8LZjTy6pFCojhWpUReI1kwpxWcWD+NnGqIkwrbNdU8/eyPq3V7HKF+IT9meKZ + dTsboh9euh+0Cw90plmu53qspGet1kg33WAxk= +MIME-Version: 1.0 +Received: by 10.42.156.6 with SMTP id x6mr153890icw.174.1315468150880; Thu, 08 + Sep 2011 00:49:10 -0700 (PDT) +Received: by 10.231.36.204 with HTTP; Thu, 8 Sep 2011 00:49:10 -0700 (PDT) +In-Reply-To: +References: <87mxehqhbl.fsf@r102.config> + +Date: Thu, 8 Sep 2011 08:49:10 +0100 +Message-ID: + +Subject: Re: RFC/PATCH emacs attachment handling +From: Mark Walters +To: Xavier Maillard +Content-Type: text/plain; charset=ISO-8859-1 +Cc: Tomi Ollila , Notmuch Mail +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 08 Sep 2011 07:49:14 -0000 + +>> To user that is: +>> +>> Pressing Enter on top of an attachment will either show the attachment on +>> buffer (in case there is 'converter' defined) or offer to save the +>> attachment. Pressing 'o' on top of an attachment will always offer to save +>> the attachment. +> +> I really do not like it this behaviour. I'd rather want easy to memorize +> keybindings: 'v'iew,'s'ave, etc. + +I am happy either way. I think a bigger question is about what re-use +of keys is sensible between the normal notmuch-show map (when not over +the button) and this new button map. For example using `a' in the +button map seems like it would cause accidental archiving of threads +(when you happen not be over the button). + +Perhaps using v and w so v means view and w means save: if over the +body it applies to all attachments if over a button just to that +single attachment. (We would still need a new key for the "open-with" +behaviour.) + +Best wishes + +Mark -- 2.26.2