From 4de58ea2972e611143bf32edd3efd211e7c94346 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Sun, 29 May 2011 22:51:10 +2000 Subject: [PATCH] Re: [PATCH 00/10] Fix 'notmuch new' atomicity issues --- 1e/7abcbce8baf2fff41d5446a36cab5ece35d722 | 112 ++++++++++++++++++++++ 1 file changed, 112 insertions(+) create mode 100644 1e/7abcbce8baf2fff41d5446a36cab5ece35d722 diff --git a/1e/7abcbce8baf2fff41d5446a36cab5ece35d722 b/1e/7abcbce8baf2fff41d5446a36cab5ece35d722 new file mode 100644 index 000000000..90525840c --- /dev/null +++ b/1e/7abcbce8baf2fff41d5446a36cab5ece35d722 @@ -0,0 +1,112 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C6ECB429E25 + for ; Sat, 28 May 2011 19:51:12 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.699 +X-Spam-Level: +X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id jYgFi6veXUdM for ; + Sat, 28 May 2011 19:51:12 -0700 (PDT) +Received: from mail-qy0-f174.google.com (mail-qy0-f174.google.com + [209.85.216.174]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 33BAE431FD0 + for ; Sat, 28 May 2011 19:51:12 -0700 (PDT) +Received: by qyk7 with SMTP id 7so459887qyk.5 + for ; Sat, 28 May 2011 19:51:11 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; + h=domainkey-signature:mime-version:sender:in-reply-to:references:date + :x-google-sender-auth:message-id:subject:from:to:content-type + :content-transfer-encoding; + bh=fIcsfb3oyr8Zbk5lDzpL/ADRFzWDaUqu3s1dlV1rli0=; + b=TTirN2sIIcv599FyekNzrYkB0GxsvcH/McxzKEhs5zmiHEqsrP3Sl82g8ZyLhlo2Vs + YpzvHuA8slQvqZbO82H/wDOiVIGygwPZcl+WVVhYj4I0yBIXIAz7Tya0EYovnc3UwILX + jAafo8WoWXEE2fBrUzVlU9ogVDVarb7ujrMLE= +DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; + h=mime-version:sender:in-reply-to:references:date + :x-google-sender-auth:message-id:subject:from:to:content-type + :content-transfer-encoding; + b=p8nMes83u9UuFIGAK+1w0P280w2AqWGsAwyVeIQWHc5AWiuuBZR0Foaca/JCffYDCz + 1gRQHpKBQvW80P0mhgEsGN3e+pJBJlJJj4qURSHJdEfbaM+Wvl1xxwiYsWwgYbK91BhC + wW8RuQikmpOlY9yzi0u8saPYt3jusLssNUNbM= +MIME-Version: 1.0 +Received: by 10.229.78.218 with SMTP id m26mr2511337qck.160.1306637470213; + Sat, 28 May 2011 19:51:10 -0700 (PDT) +Sender: amdragon@gmail.com +Received: by 10.229.188.68 with HTTP; Sat, 28 May 2011 19:51:10 -0700 (PDT) +In-Reply-To: +References: <1298015940-31986-1-git-send-email-amdragon@mit.edu> + + +Date: Sat, 28 May 2011 22:51:10 -0400 +X-Google-Sender-Auth: IR4158In8OflXC2LNDnrvoUwOYI +Message-ID: +Subject: Re: [PATCH 00/10] Fix 'notmuch new' atomicity issues +From: Austin Clements +To: notmuch@notmuchmail.org +Content-Type: text/plain; charset=ISO-8859-1 +Content-Transfer-Encoding: quoted-printable +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 29 May 2011 02:51:12 -0000 + +Rebased to current master (cb8418) as atomic-new-v4 (aka +for-review/atomic-new-v4). + +On Wed, May 4, 2011 at 4:30 PM, Austin Clements wrote: +> jrollins found a timing bug in the atomicity test. =A0A fix, plus beefed +> up test comments are on a new atomic-new-v3 (and +> for-review/atomic-new-v3) branch at +> =A0http://awakening.csail.mit.edu/git/notmuch.git/ +> Since this is more than a rebase, I'll email an update to the one +> changed patch in the series. +> +> On Tue, Apr 26, 2011 at 12:13 AM, Austin Clements wrot= +e: +>> Bump. =A0Now rebased against current head (with no conflicts) on +>> atomic-new-v2 (and for-review/atomic-new-v2) at +>> =A0http://awakening.csail.mit.edu/git/notmuch.git/ +>> +>> On Fri, Feb 18, 2011 at 2:58 AM, Austin Clements wrot= +e: +>>> This patch series modifies notmuch new to perform all operations +>>> atomically and to perform maildir flag synchronization eagerly. =A0As a +>>> result, notmuch new can be interrupted without risking database +>>> consistency or losing track of messages, but still without losing +>>> progress in the middle of a big import. =A0This also paves the way for +>>> fixing the antisocial locking behavior of notmuch new. +>>> +>>> While there are quite a few patches in the series, each one is +>>> bite-sized and you can see the number of atomicity violations dropping +>>> with nearly every patch using the test added by the first patch. +>>> +>>> On my test machine, these patches have no affect on performance. +>>> +>>> These patches are also available on the atomic-new-v1 branch at +>>> =A0http://awakening.csail.mit.edu/git/notmuch.git/ +>>> +>>> _______________________________________________ +>>> notmuch mailing list +>>> notmuch@notmuchmail.org +>>> http://notmuchmail.org/mailman/listinfo/notmuch +>>> +>> +> -- 2.26.2