From: Blake Jones Date: Tue, 20 Aug 2013 16:29:27 +0000 (+1700) Subject: Re: [PATCH 4/4] timegm: add portable implementation (Solaris support) X-Git-Url: http://git.tremily.us/?p=notmuch-archives.git;a=commitdiff_plain;h=4739d17653840797d9f83223b78f716109eae584 Re: [PATCH 4/4] timegm: add portable implementation (Solaris support) --- diff --git a/f3/2ce3c886e170de8087eac2cf4312d6705e55f7 b/f3/2ce3c886e170de8087eac2cf4312d6705e55f7 new file mode 100644 index 000000000..d056bdc70 --- /dev/null +++ b/f3/2ce3c886e170de8087eac2cf4312d6705e55f7 @@ -0,0 +1,73 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 36F4C431E62 + for ; Tue, 20 Aug 2013 09:29:46 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id XRV5cgdr9kRA for ; + Tue, 20 Aug 2013 09:29:38 -0700 (PDT) +Received: from foo.net (70-36-235-136.dsl.static.sonic.net [70.36.235.136]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id CB2B6431FB6 + for ; Tue, 20 Aug 2013 09:29:37 -0700 (PDT) +Received: from foo.net (localhost [127.0.0.1]) + by foo.net (8.14.5+Sun/8.14.5) with ESMTP id r7KGTR78027224; + Tue, 20 Aug 2013 09:29:27 -0700 (PDT) +To: Tomi Ollila +Subject: Re: [PATCH 4/4] timegm: add portable implementation (Solaris support) +In-Reply-To: Your message of "Tue, 20 Aug 2013 19:03:42 +0300." + +Date: Tue, 20 Aug 2013 09:29:27 -0700 +Message-ID: <27223.1377016167@foo.net> +From: Blake Jones +X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2 + (foo.net [127.0.0.1]); Tue, 20 Aug 2013 09:29:27 -0700 (PDT) +Cc: notmuch@notmuchmail.org, Vladimir Marek +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 20 Aug 2013 16:29:46 -0000 + +> The copyright header gives FSF "owner"ship to the file -- which would +> be fine by the project -- but does assigning copyright to the FSF work +> like this... ... I started to look around and found (among other +> pages) this: +> +> http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=doc/Copyright/conditions.text;h=6e19adf0233900c9169 +> e10fe7e0aa8d1feb73996;hb=HEAD +> +> Maybe for liability reasons FSF needs more than just stating the +> copyright at the beginning of file... I don't know -- but if this is +> the case maybe the easiest thing is to remove (amend) the Copyright +> line out of the file. + +I don't really care what sort of copyright it has. Vladimir is the one +with the up-to-date tree at this point, so he would be best positioned +to update the text with whatever works best for the rest of notmuch. + +> In getline.c, and getdelim.c the code is taken from glibc. What I've +> understood this timegm.c is new art ? + +To the best of my recollection, yes, I implemented this version of +timegm() from scratch, based on my understanding of what it needed to +do. + +Blake