From: Austin Clements Date: Tue, 23 Oct 2012 04:23:26 +0000 (+2000) Subject: Re: [PATCH v5 4/9] test: add smoke tests for the date/time parser module X-Git-Url: http://git.tremily.us/?p=notmuch-archives.git;a=commitdiff_plain;h=4342b0005a0afc264921717c26d9bf61bc84f4bc Re: [PATCH v5 4/9] test: add smoke tests for the date/time parser module --- diff --git a/ab/a4f90bf9563630c1ac9350f7a6d95cf4e7fe5d b/ab/a4f90bf9563630c1ac9350f7a6d95cf4e7fe5d new file mode 100644 index 000000000..3f20771f0 --- /dev/null +++ b/ab/a4f90bf9563630c1ac9350f7a6d95cf4e7fe5d @@ -0,0 +1,189 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 234C5431FAF + for ; Mon, 22 Oct 2012 21:23:32 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id CjmIT5I4bvaa for ; + Mon, 22 Oct 2012 21:23:31 -0700 (PDT) +Received: from dmz-mailsec-scanner-5.mit.edu (DMZ-MAILSEC-SCANNER-5.MIT.EDU + [18.7.68.34]) + by olra.theworths.org (Postfix) with ESMTP id 088AF431FAE + for ; Mon, 22 Oct 2012 21:23:30 -0700 (PDT) +X-AuditID: 12074422-b7f746d0000008cc-59-50861bc0fd69 +Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) + by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP + id B6.1D.02252.0CB16805; Tue, 23 Oct 2012 00:23:28 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q9N4NRWO003459; + Tue, 23 Oct 2012 00:23:28 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q9N4NQmU026482 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Tue, 23 Oct 2012 00:23:27 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1TQW1W-0001cW-2Z; Tue, 23 Oct 2012 00:23:26 -0400 +Date: Tue, 23 Oct 2012 00:23:26 -0400 +From: Austin Clements +To: Jani Nikula +Subject: Re: [PATCH v5 4/9] test: add smoke tests for the date/time parser + module +Message-ID: <20121023042326.GP14861@mit.edu> +References: + <606a94d565e6b21abfc59d6ba9676a807d669127.1350854171.git.jani@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: + <606a94d565e6b21abfc59d6ba9676a807d669127.1350854171.git.jani@nikula.org> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFvrLIsWRmVeSWpSXmKPExsUixCmqrHtAui3AYM1UPYum6c4W12/OZHZg + 8rh1/zW7x7NVt5gDmKK4bFJSczLLUov07RK4Mo71T2Ev+CNX8eb6PLYGxtfiXYwcHBICJhI7 + ehm7GDmBTDGJC/fWs3UxcnEICexjlFh14zULSEJIYAOjxM81GhD2SSaJiauqIewljBIzTvKB + zGERUJV4OTUEJMwmoCGxbf9ysJkiAooSm0/uB7OZBaQlvv1uZgKxhQWCJTa+3MEOYvMK6Ehc + 3/yKCWSMkECdxPv3ARBhQYmTM5+wQLRqSdz49xKsBGTM8n8cIGFOgTCJCVP+gU0UFVCRmHJy + G9sERqFZSLpnIemehdC9gJF5FaNsSm6Vbm5iZk5xarJucXJiXl5qka6pXm5miV5qSukmRlAo + s7so7WD8eVDpEKMAB6MSD++Dg60BQqyJZcWVuYcYJTmYlER5XSTbAoT4kvJTKjMSizPii0pz + UosPMUpwMCuJ8CoHAJXzpiRWVqUW5cOkpDlYlMR5r6Xc9BcSSE8sSc1OTS1ILYLJynBwKEnw + fpICGipYlJqeWpGWmVOCkGbi4AQZzgM0/BpIDW9xQWJucWY6RP4Uo6KUOO8FkIQASCKjNA+u + F5ZqXjGKA70izPtaFKiKB5im4LpfAQ1mAhpszgNydXFJIkJKqoFRqG4qyw1pvbPbG/P232EJ + D821L2Le/snI50+o4ZagrU+9l81S2+545MmmhyGb2gqebL9tJbk21dbb475YSaPee+5WnbK5 + 9j83MzGezLk3j4FZ+mWGU6OYVZD1nt8nLTt/6YUmOkSnLvzZPGvdzY81EmLiR0VXBxTIcq36 + unfzK4f291wfJ9YpsRRnJBpqMRcVJwIA4Xfj2hADAAA= +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 23 Oct 2012 04:23:32 -0000 + +Quoth Jani Nikula on Oct 22 at 12:22 am: +> Test the date/time parser module directly, independent of notmuch, +> using the parse-time test tool. +> +> Credits to Michal Sojka for writing most of the +> tests. +> --- +> test/notmuch-test | 1 + +> test/parse-time-string | 71 ++++++++++++++++++++++++++++++++++++++++++++++++ +> 2 files changed, 72 insertions(+) +> create mode 100755 test/parse-time-string +> +> diff --git a/test/notmuch-test b/test/notmuch-test +> index cc732c3..7eadfdf 100755 +> --- a/test/notmuch-test +> +++ b/test/notmuch-test +> @@ -60,6 +60,7 @@ TESTS=" +> emacs-hello +> emacs-show +> missing-headers +> + parse-time-string +> " +> TESTS=${NOTMUCH_TESTS:=$TESTS} +> +> diff --git a/test/parse-time-string b/test/parse-time-string +> new file mode 100755 +> index 0000000..862e701 +> --- /dev/null +> +++ b/test/parse-time-string +> @@ -0,0 +1,71 @@ +> +#!/usr/bin/env bash +> +test_description="date/time parser module" +> +. ./test-lib.sh +> + +> +# Sanity/smoke tests for the date/time parser independent of notmuch +> + +> +_date () +> +{ +> + date -d "$*" +%s +> +} +> + +> +_parse_time () +> +{ +> + ${TEST_DIRECTORY}/parse-time --format=%s "$*" +> +} +> + +> +test_begin_subtest "date(1) default format without TZ code" +> +test_expect_equal "$(_parse_time Fri Aug 3 23:06:06 2012)" "$(_date Fri Aug 3 23:06:06 2012)" +> + +> +test_begin_subtest "date(1) --rfc-2822 format" +> +test_expect_equal "$(_parse_time Fri, 03 Aug 2012 23:07:46 +0100)" "$(_date Fri, 03 Aug 2012 23:07:46 +0100)" +> + +> +test_begin_subtest "date(1) --rfc=3339=seconds format" +> +test_expect_equal "$(_parse_time 2012-08-03 23:09:37+03:00)" "$(_date 2012-08-03 23:09:37+03:00)" +> + +> +test_begin_subtest "Date parser tests" +> +REFERENCE=$(_date Tue Jan 11 11:11:00 +0000 2011) +> +cat < INPUT +> +now ==> Tue Jan 11 11:11:00 +0000 2011 +> +2010-1-1 ==> ERROR: 5 + +It would be nice if these errors were strings. I have no idea if "5" +is the right error for this. + +> +Jan 2 ==> Sun Jan 02 11:11:00 +0000 2011 +> +Mon ==> Mon Jan 10 11:11:00 +0000 2011 +> +last Friday ==> ERROR: 4 +> +2 hours ago ==> ERROR: 1 +> +last month ==> Sat Dec 11 11:11:00 +0000 2010 +> +month ago ==> ERROR: 1 +> +8am ==> Tue Jan 11 08:00:00 +0000 2011 +> +9:15 ==> Tue Jan 11 09:15:00 +0000 2011 +> +12:34 ==> Tue Jan 11 12:34:00 +0000 2011 +> +monday ==> Mon Jan 10 11:11:00 +0000 2011 +> +yesterday ==> Mon Jan 10 11:11:00 +0000 2011 +> +tomorrow ==> ERROR: 1 +> + ==> Tue Jan 11 11:11:00 +0000 2011 # empty string is reference time +> + +> +Aug 3 23:06:06 2012 ==> Fri Aug 03 23:06:06 +0000 2012 # date(1) default format without TZ code +> +Fri, 03 Aug 2012 23:07:46 +0100 ==> Fri Aug 03 22:07:46 +0000 2012 # rfc-2822 +> +2012-08-03 23:09:37+03:00 ==> Fri Aug 03 20:09:37 +0000 2012 # rfc-3339 seconds +> + +> +10s ==> Tue Jan 11 11:10:50 +0000 2011 +> +19701223s ==> Fri May 28 10:37:17 +0000 2010 +> +19701223 ==> Wed Dec 23 11:11:00 +0000 1970 +> + +> +19701223 +0100 ==> Wed Dec 23 11:11:00 +0000 1970 # Timezone is ignored without an error +> + +> +today ==^> Tue Jan 11 23:59:59 +0000 2011 +> +today ==_> Tue Jan 11 00:00:00 +0000 2011 +> + +> +thisweek ==^> Sat Jan 15 23:59:59 +0000 2011 +> +thisweek ==_> Sun Jan 09 00:00:00 +0000 2011 +> + +> +two months ago==> ERROR: 1 # "ago" is not supported +> +two months ==> Thu Nov 11 11:11:00 +0000 2010 +> + +> +@1348569850 ==> Tue Sep 25 10:44:10 +0000 2012 +> +@10 ==> Thu Jan 01 00:00:10 +0000 1970 + +Very nice. The only thing that jumps out at me is that there are no +==^^> tests, though it would be interesting to run a code coverage +tool to see how thorough these tests are. + +> +EOF +> + +> +${TEST_DIRECTORY}/parse-time --ref=${REFERENCE} < INPUT > OUTPUT +> +test_expect_equal_file INPUT OUTPUT +> + +> +test_done