Re: [PATCH] emacs: wash: make word-wrap bound message width

diff --git a/64/cfcd47535168a2d4e2f105cf4a61dab8fe9411 b/64/cfcd47535168a2d4e2f105cf4a61dab8fe9411
new file mode 100644 (file)
index 0000000..ac14cb0
--- /dev/null
+++ b/64/cfcd47535168a2d4e2f105cf4a61dab8fe9411
@@ -0,0 +1,114 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id A04726DE0BAC\r
+ for <notmuch@notmuchmail.org>; Sat, 20 Aug 2016 13:08:29 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.557\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.557 tagged_above=-999 required=5 tests=[AWL=-0.095,\r
+  SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id vfwggdjR023N for <notmuch@notmuchmail.org>;\r
+ Sat, 20 Aug 2016 13:08:29 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id EEAF36DE0B7C\r
+ for <notmuch@notmuchmail.org>; Sat, 20 Aug 2016 13:08:28 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 5B434100090;\r
+ Sat, 20 Aug 2016 23:08:09 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: wash: make word-wrap bound message width\r
+In-Reply-To: <1467791251-6823-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1467791251-6823-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.22+61~geeecb9e (https://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 20 Aug 2016 23:08:09 +0300\r
+Message-ID: <m2h9afmceu.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.22\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 20 Aug 2016 20:08:29 -0000\r
+\r
+On Wed, Jul 06 2016, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> Previously if notmuch-wash-wrap-lines-length was set then all messages\r
+> would be wrapped at this value (or window-width if that is\r
+> smaller). This was done regardless of the message's depth in a thread:\r
+> for example, if the n.w.w.l.l is 80 and the messages depth is 20\r
+> (so indented 20 by default) the messages text only got 60 characters\r
+> of space.\r
+>\r
+> This commit changes that so a message always gets the full n.w.w.l.l\r
+> of width regardless of its indentation (unless that goes over\r
+> window-width of course).\r
+> ---\r
+>\r
+> This is what I would like -- I don't know if anyone would like to keep\r
+> the previous behaviour as an option. The code-part for that is easy, but getting\r
+> the docstrings and and defcustoms right is not clear.\r
+\r
+The change looks good to me -- but I just don't understand why someone\r
+would set notmuch-wash-wrap-lines-length to something else than nil\r
+-- and if it is set to some number what the behaviour should be ?\r
+\r
+Tomi\r
+\r
+\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+> emacs/notmuch-wash.el | 6 +++---\r
+>  1 file changed, 3 insertions(+), 3 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-wash.el b/emacs/notmuch-wash.el\r
+> index 57e6dfa..e16b8cc 100644\r
+> --- a/emacs/notmuch-wash.el\r
+> +++ b/emacs/notmuch-wash.el\r
+> @@ -121,8 +121,8 @@ collapse the remaining lines into a button."\r
+>  \r
+>  If this is nil, lines in messages will be wrapped to fit in the\r
+>  current window. If this is a number, lines will be wrapped after\r
+> -this many characters or at the window width (whichever one is\r
+> -lower)."\r
+> +this many characters (ignoring indentation due to thread depth)\r
+> +or at the window width (whichever one is lower)."\r
+>    :type '(choice (const :tag "window width" nil)\r
+>               (integer :tag "number of characters"))\r
+>    :group 'notmuch-wash)\r
+> @@ -336,7 +336,7 @@ the wrapped text are maintained."\r
+>  \r
+>    (let* ((coolj-wrap-follows-window-size nil)\r
+>       (limit (if (numberp notmuch-wash-wrap-lines-length)\r
+> -                (min notmuch-wash-wrap-lines-length\r
+> +                (min (+ notmuch-wash-wrap-lines-length depth)\r
+>                       (window-width))\r
+>                (window-width)))\r
+>       (fill-column (- limit\r
+> -- \r
+> 2.1.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> https://notmuchmail.org/mailman/listinfo/notmuch\r