Return-Path: <bremner@unb.ca>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id DAEC8431FC2
	for <notmuch@notmuchmail.org>; Fri, 29 Mar 2013 18:48:52 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id xL8nUo9RvUfg for <notmuch@notmuchmail.org>;
	Fri, 29 Mar 2013 18:48:52 -0700 (PDT)
Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 915ED431FBF
	for <notmuch@notmuchmail.org>; Fri, 29 Mar 2013 18:48:52 -0700 (PDT)
Received: from remotemail by tesseract.cs.unb.ca with local (Exim 4.80)
	(envelope-from <bremner@unb.ca>)
	id 1ULkuZ-000616-AF; Fri, 29 Mar 2013 22:48:51 -0300
Received: (nullmailer pid 15258 invoked by uid 1000);
	Fri, 29 Mar 2013 23:59:56 -0000
From: David Bremner <david@tethera.net>
To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v4 06/12] test: add tests for insert
In-Reply-To: <1359029288-12132-7-git-send-email-novalazy@gmail.com>
References: <1359029288-12132-1-git-send-email-novalazy@gmail.com>
	<1359029288-12132-7-git-send-email-novalazy@gmail.com>
User-Agent: Notmuch/0.15.1 (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-pc-linux-gnu)
Date: Fri, 29 Mar 2013 19:59:56 -0400
Message-ID: <87d2uhiwoz.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Mar 2013 01:48:53 -0000


It took longer than I thought (of course) but I finally finished looking
at the first 6 patches. 

I already mentioned a minor man page issue in a seperate message.

I took a second pass through 03/12, and I think I would prefer thethe
control flow of insert_message be closer to the standard style in
notmuch of using a return value variable and a single cleanup block at
the end.  Reasonable people can disagree about issues of style, but in
the end consistency of the code base is also important.

d