Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id DC7824196F0 for ; Sun, 25 Apr 2010 08:59:37 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SwGtC40teKqk for ; Sun, 25 Apr 2010 08:59:37 -0700 (PDT) Received: from mail.mymadcat.com (mymadcat.com [213.251.163.154]) by olra.theworths.org (Postfix) with ESMTP id F1F15431FC1 for ; Sun, 25 Apr 2010 08:59:36 -0700 (PDT) Received: by mail.mymadcat.com (Postfix, from userid 504) id 25C933DB69; Sun, 25 Apr 2010 17:59:36 +0200 (CEST) Received: from mail.mymadcat.com (localhost.localdomain [127.0.0.1]) by mail.mymadcat.com (Postfix) with ESMTPA id 495373DAC0; Sun, 25 Apr 2010 17:59:35 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Date: Sun, 25 Apr 2010 17:59:35 +0200 From: Adrien Bustany To: Chris Wilson Subject: Re: [PATCH] Makefile: specify libnotmuch.so location with -rpath In-Reply-To: <1272209920-362-1-git-send-email-chris@chris-wilson.co.uk> References: <1272209920-362-1-git-send-email-chris@chris-wilson.co.uk> Message-ID: <8d8e848a456d44b7cc0fe8968e79924b@localhost> X-Sender: madcat@mymadcat.com User-Agent: RoundCube Webmail/0.3-beta Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Apr 2010 15:59:38 -0000 On Sun, 25 Apr 2010 16:38:40 +0100, Chris Wilson wrote: > In order to handle installation into user directories, it is convenient > to encode the library location into the search path for the notmuch > executable. This is achieved for the GNU linker with the -rpath > argument. > --- > Makefile.local | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Makefile.local b/Makefile.local > index 5bb570b..77d2c45 100644 > --- a/Makefile.local > +++ b/Makefile.local > @@ -31,7 +31,7 @@ GPG_FILE=$(SHA1_FILE).asc > # Smash together user's values with our extra values > FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CFLAGS) $(WARN_CFLAGS) > $(CONFIGURE_CFLAGS) $(extra_cflags) > FINAL_CXXFLAGS = $(CXXFLAGS) $(WARN_CXXFLAGS) $(CONFIGURE_CXXFLAGS) > $(extra_cflags) $(extra_cxxflags) > -FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch > +FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Wl,-rpath=$(prefix)/lib -Llib > -lnotmuch > FINAL_NOTMUCH_LINKER = CC > ifneq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1) > FINAL_NOTMUCH_LDFLAGS += $(CONFIGURE_LDFLAGS) Hello Chris, I know that many distros (among them Fedora, see https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath ) discourage the use of rpath. Do you think it could be an option set at configure time (set rpath or not) ? Cheers Adrien