Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 2CF3B4196F2 for ; Thu, 4 Nov 2010 07:46:12 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U29Z1iPzL600 for ; Thu, 4 Nov 2010 07:46:01 -0700 (PDT) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) by olra.theworths.org (Postfix) with ESMTP id 8AF444196F0 for ; Thu, 4 Nov 2010 07:46:01 -0700 (PDT) Received: by wwj40 with SMTP id 40so2136824wwj.2 for ; Thu, 04 Nov 2010 07:46:00 -0700 (PDT) Received: by 10.227.132.197 with SMTP id c5mr825329wbt.89.1288881960420; Thu, 04 Nov 2010 07:46:00 -0700 (PDT) Received: from ut.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com [81.149.164.25]) by mx.google.com with ESMTPS id b30sm8621919wbb.16.2010.11.04.07.45.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 04 Nov 2010 07:45:58 -0700 (PDT) Received: by ut.hh.sledj.net (Postfix, from userid 1000) id C4CC759405B; Thu, 4 Nov 2010 14:45:33 +0000 (GMT) To: Michal Sojka , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: Do not color non-matching authors by tag In-Reply-To: <87vd4djhy2.fsf@steelpick.2x.cz> References: <1287726122-5643-1-git-send-email-sojkam1@fel.cvut.cz> <878w1942i6.fsf@ut.hh.sledj.net> <87vd4djhy2.fsf@steelpick.2x.cz> User-Agent: Notmuch/0.4 (http://notmuchmail.org) Emacs/23.2.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Thu, 04 Nov 2010 14:45:33 +0000 Message-ID: <87zktp2lma.fsf@ut.hh.sledj.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2010 14:46:12 -0000 On Thu, 04 Nov 2010 15:12:53 +0100, Michal Sojka wrote: > > Michal, was this addressed by the patch that Carl recently merged? > > (Commit f99ad42da03afd638bfdfdea92d1cbdd3b510b8f in my copy of the > > repository.) > > Unfortunately not. In your patch, the overlay changes the color/face of the > whole line while my patch change the color/face of all parts of the line > except for non-matching authors. With my patch non-matched autors were I understand now. This seems somewhat like a policy decision, though. If I indicate that I want the foreground text for a particular line to be red, should the formatting of non-matching authors override that? (My own approach has been to have `notmuch-search-line-faces' always specify a background colour whereas `notmuch-search-non-matching-authors' (or any of the columnar faces) specify a foreground colour and/or slant.)