Date: Sat, 14 Jan 2012 19:14:27 -0500
From: Austin Clements <amdragon@MIT.EDU>
To: Jameson Graef Rollins <jrollins@finestructure.net>
Subject: Re: [PATCH v2 3/3] search: Support automatic tag exclusions
Message-ID: <20120115001427.GG1801@mit.edu>
References: <1326258173-21163-1-git-send-email-amdragon@mit.edu>
	<1326496024-14403-1-git-send-email-amdragon@mit.edu>
	<1326496024-14403-4-git-send-email-amdragon@mit.edu>
	<87wr8tsvit.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87wr8tsvit.fsf@servo.finestructure.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org
Precedence: list

Quoth Jameson Graef Rollins on Jan 14 at  3:40 pm:
> This patch looks fine.  Philosophical UI discussion to follow:
> 
> On Fri, 13 Jan 2012 18:07:04 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> > +    if (notmuch_config_get_auto_exclude_tags (config, &tmp) == NULL) {
> > +	const char *tags[] = { "deleted", "spam" };
> > +	notmuch_config_set_auto_exclude_tags (config, tags, 2);
> > +    }
> 
> This creates the config section with the exclude list pre-set to
> "deleted;spam".  I personally have no problem with this, since I was
> going to be setting exactly that anyway.  However, assuming we decide to
> have this be the default in the CLI, should we therefore add support for
> it in the emacs UI?  I've been going back and forth on this (as readers
> are well aware), and have most recently rejected the idea that we should
> add delete support to the emacs UI.  However, if we are excluding
> "deleted" tags by default, then I'm going to go back and say that we
> should include the keybindings to "delete" messages.  Comments?

It's not that Emacs doesn't support the deleted tag.  You can always
+deleted<RET>, and this even seems like a pretty natural thing to do.
To me, the question is whether there should be a shortcut to do this.
I'm probably not one to answer this, since I don't plan to use the
deleted tag and hence using this binding would only ever be an
accident (though I will use the spam tag and I don't think I need a
binding for that; perhaps I would feel differently if my spam filters
were less effective).

> If people think we should exclude "deleted;spam" by default, and agree
> that we should also add delete support in the emacs UI, I'll go ahead
> and rework my keybinding patches.
> 
> jamie.