Date: Thu, 10 Nov 2011 14:28:36 -0500
From: Austin Clements <amdragon@MIT.EDU>
To: Jameson Graef Rollins <jrollins@finestructure.net>
Subject: Re: [PATCH] test: Use env to set TMPDIR when running emacs in screen.
Message-ID: <20111110192836.GN2658@mit.edu>
References: <id:878vnomntf.fsf@servo.finestructure.net>
	<1320944375-29843-1-git-send-email-jrollins@finestructure.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1320944375-29843-1-git-send-email-jrollins@finestructure.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

This looks good to me, though it would be good to add a comment
explaining why this dance is necessary.  Perhaps something along the
lines of

# The emacs server places its socket in TMPDIR, but ld.so unsets
# TMPDIR when loading setgid binaries like screen, so we must
# explicitly pass TMPDIR through to emacs.

Quoth Jameson Graef Rollins on Nov 10 at  8:59 am:
> This is to get around a bug where screen unsets TMPDIR.  This causes
> problems for users who set TMPDIR to something other than it's default
> (/tmp).
> ---
>  test/test-lib.sh |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index ff5183f..108537e 100755
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -842,7 +842,9 @@ test_emacs () {
>  	if [ -z "$EMACS_SERVER" ]; then
>  		EMACS_SERVER="notmuch-test-suite-$$"
>  		# start a detached screen session with an emacs server
> -		screen -S "$EMACS_SERVER" -d -m "$TMP_DIRECTORY/run_emacs" \
> +		screen -S "$EMACS_SERVER" -d -m \
> +		    env TMPDIR="$TMPDIR" \
> +		    "$TMP_DIRECTORY/run_emacs" \
>  			--no-window-system \
>  			--eval "(setq server-name \"$EMACS_SERVER\")" \
>  			--eval '(server-start)' \