Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 218E7431FD0 for ; Wed, 20 Jul 2011 16:32:06 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.1 X-Spam-Level: X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xIwM9Los7Pai for ; Wed, 20 Jul 2011 16:32:04 -0700 (PDT) Received: from ks3536.kimsufi.com (schnouki.net [87.98.217.222]) by olra.theworths.org (Postfix) with ESMTP id 108FF431FB6 for ; Wed, 20 Jul 2011 16:32:04 -0700 (PDT) Received: from localhost.localdomain (nancy.schnouki.net [78.238.0.45]) by ks3536.kimsufi.com (Postfix) with ESMTPSA id 988B46A06A9; Thu, 21 Jul 2011 01:40:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=schnouki.net; s=key-schnouki; t=1311205251; bh=AzOY3XC9Y/8DQNfUKd52GRUXKZJxgw6VulNPhWr91HI=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References; b=KMBBMAeF8qi+BOuqN77US6WsD9Be8H2cLAq05srep4oltLCZNigwI/P5h21QvUr1/ XQOJV6Ur/vuOHyjtnykyBImm3fQsQGkzMSfzfWZGJqqgDekPlr2DgUeulnNkQLAfnr IrC8J1bHT4bBFeLNM3hOLidaBTF+f1p94xY67xN4= From: Thomas Jost To: David Bremner , notmuch@notmuchmail.org Subject: [PATCH] libnotmuch: only build symbols list after the modules are built Date: Thu, 21 Jul 2011 01:31:37 +0200 Message-Id: <1311204697-14701-1-git-send-email-schnouki@schnouki.net> X-Mailer: git-send-email 1.7.6 In-Reply-To: <87aac8ev8z.fsf@convex-new.cs.unb.ca> References: <87aac8ev8z.fsf@convex-new.cs.unb.ca> X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2011 23:32:06 -0000 If the notmuch.sym target does not explicitly depend on $(libnotmuch_modules), gen-version-script.sh may be run before all the .o files are created, for example when doing a parallel build on a machine with many cores. --- Hi David, Here's an updated version of the patch with a shorter commit message. For the record, the build log I sent earlier was obtained on my work PC, which has two 8-core CPUs. No problem on my laptop with its dual-core CPU though :) Regards, Thomas lib/Makefile.local | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/Makefile.local b/lib/Makefile.local index 9210f0e..fbc2f6a 100644 --- a/lib/Makefile.local +++ b/lib/Makefile.local @@ -74,7 +74,7 @@ $(dir)/libnotmuch.a: $(libnotmuch_modules) $(dir)/$(LIBNAME): $(libnotmuch_modules) notmuch.sym $(call quiet,CXX $(CXXFLAGS)) $(libnotmuch_modules) $(FINAL_LIBNOTMUCH_LDFLAGS) $(LIBRARY_LINK_FLAG) -o $@ -notmuch.sym: lib/notmuch.h +notmuch.sym: lib/notmuch.h $(libnotmuch_modules) sh lib/gen-version-script.sh $< $(libnotmuch_modules) > $@ $(dir)/$(SONAME): $(dir)/$(LIBNAME) -- 1.7.6