From: David Bremner <david@tethera.net>
To: Austin Clements <amdragon@MIT.EDU>, Tomi Ollila <tomi.ollila@iki.fi>
Subject: Re: [PATCH 1/3] cli: add insert --must-index option
In-Reply-To: <20131023193209.GF20337@mit.edu>
References: <1374365254-13227-1-git-send-email-novalazy@gmail.com>
	<87ip048gbj.fsf@qmul.ac.uk> <20130727151510.GA13750@hili.localdomain>
	<87hadtxfrr.fsf@qmul.ac.uk> <20130912001349.GA18821@hili.localdomain>
	<87zjqhv264.fsf@zancas.localnet> <m238o9fguj.fsf@guru.guru-group.fi>
	<87bo2xtdp2.fsf@unb.ca> <m2eh7bu7t5.fsf@guru.guru-group.fi>
	<20131023193209.GF20337@mit.edu>
User-Agent: Notmuch/0.16+97~g6878b0b (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Wed, 23 Oct 2013 21:05:33 -0300
Message-ID: <87ob6fv8he.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
Cc: notmuch@notmuchmail.org
Precedence: list

Austin Clements <amdragon@MIT.EDU> writes:

> And in libnotmuch, we would do something like
>
> notmuch_status_t
> notmuch_database_open (const char *path,
>                        notmuch_database_mode_t mode,
>                        const notmuch_options_t *options,
>                        notmuch_database_t **database)
> {
>     notmuch_option_t real_options = NOTMUCH_OPTIONS_INIT;
>     if (real_options.options_length < options.options_length)
>         return error;
>     memmove(&real_options, options, options.options_length);
>     // ...
> }
>

Does the C standard guarantee that if two structs have the same initial
set of members, that they are aligned in a compatible way? I suppose it
must work, but I'm still curious.

Yet another approach would be to pass in array of descriptors, something
like the command line argument parsing code does now.

libnotmuch_opt_desc_t options[] = {
  { LIBNOTMUCH_OPT_LOGHOOK, loghook },
  { 0, 0} 
}

I guess passing a (void *) as the second element of the pair?

Of course it's a bit more work to unpack this way.