Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id AE5A44196F0 for ; Thu, 4 Nov 2010 12:30:04 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VLUYJGSW2HTQ for ; Thu, 4 Nov 2010 12:29:51 -0700 (PDT) Received: from mail-wy0-f181.google.com (mail-wy0-f181.google.com [74.125.82.181]) by olra.theworths.org (Postfix) with ESMTP id E20CE40D154 for ; Thu, 4 Nov 2010 12:29:50 -0700 (PDT) Received: by wyb40 with SMTP id 40so2339395wyb.26 for ; Thu, 04 Nov 2010 12:29:50 -0700 (PDT) Received: by 10.227.133.134 with SMTP id f6mr1083898wbt.202.1288898989110; Thu, 04 Nov 2010 12:29:49 -0700 (PDT) Received: from ut.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com [81.149.164.25]) by mx.google.com with ESMTPS id h29sm235281wbc.21.2010.11.04.12.29.46 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 04 Nov 2010 12:29:46 -0700 (PDT) Received: by ut.hh.sledj.net (Postfix, from userid 1000) id 38AF159405B; Thu, 4 Nov 2010 19:29:22 +0000 (GMT) To: Carl Worth , notmuch@notmuchmail.org Subject: Re: rfc: improved MIME handling (multipart) In-Reply-To: <87vd4kpn4a.fsf@yoom.home.cworth.org> References: <87y6fsoxls.fsf@ut.hh.sledj.net> <87vd4kpn4a.fsf@yoom.home.cworth.org> User-Agent: Notmuch/0.4 (http://notmuchmail.org) Emacs/23.2.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Thu, 04 Nov 2010 19:29:22 +0000 Message-ID: <87sjzg3n1p.fsf@ut.hh.sledj.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Nov 2010 19:30:04 -0000 On Fri, 29 Oct 2010 16:58:45 -0700, Carl Worth wrote: > On Mon, 10 May 2010 11:33:03 +0100, David Edmondson wrote: > > A (third) attempt at improved MIME handling, specifically for multipart, > > is at: > > http://github.com/dme/notmuch/tree/mp3 > > git://github.com/dme/notmuch.git (branch 'mp3') > > Hi David, > > I went to pull this, but I couldn't find satisfactory commit > messages. Things like "multipart: Fix part counting" aren't descriptive > enough for me. What was broken? How was it fixed? I was genuinely asking for comments rather than suggesting that those changes get committed as-is (although they do work). See more below. > A good test for a bug-fix commit message is "Could a reasonable person > (skilled in the art) read my commit message and confidently create a > test case for my fix?". If not, please add more detail. Understood and agreed. To improve the treatment of multipart/* messages in the emacs interface it's necessary to expose more of the underlying structure of the messages than is currently available. This affects mostly the JSON formatted output, though I expect that some of the other formats may also see small changes. I'd like some guidance and/or feedback on a way to do that which is likely to be acceptable. The previous attempt is most concisely described by this change: https://github.com/dme/notmuch/commit/2268fee48e7295519cabfd6bcb8a7aa2f8817401 though that is now obviously out of date (as well as requiring a couple of follow-on fixes and consequent changes). It is also quite messy.