Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 626B6431FD0 for ; Wed, 26 Jan 2011 20:49:45 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.99 X-Spam-Level: X-Spam-Status: No, score=-0.99 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jh6k1IlK7pLg; Wed, 26 Jan 2011 20:49:44 -0800 (PST) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 77E56431FB5; Wed, 26 Jan 2011 20:49:44 -0800 (PST) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 81D432540DF; Thu, 27 Jan 2011 14:49:43 +1000 (EST) From: Carl Worth To: Jameson Rollins , Notmuch Mail Subject: Re: [PATCH] emacs: send notmuch-query stderr to /dev/null In-Reply-To: <878vy7tjog.fsf@servo.finestructure.net> References: <878vy7tjog.fsf@servo.finestructure.net> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Thu, 27 Jan 2011 14:49:43 +1000 Message-ID: <87lj27ymqg.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2011 04:49:45 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Wed, 26 Jan 2011 12:57:50 -0800, Jameson Rollins wrote: > The call-process to notmuch in notmuch-query.el was previously sending > stderr into the output buffer. This means that if there is any stderr > the JSON parsing breaks. Unfortunately call-process does not support > sending stderr to a separate buffer or to the minibuffer [0], but it > does support sending it to /dev/null. So we do that here instead. >=20 > [0] a bug was filed against emacs (#7842) Thanks! I had wondered what those json errors were about. I've committed this. I am a bit concerned about throwing the error output away, of course, (so we'll wait for that fix to emacs---thanks for submitting a bug report). Do you have a sense of what kinds of output we are getting on stderr? =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFNQPln6JDdNq8qSWgRAqg7AJ4igOkZRomZTzRBh9LsBsbq8Eq0awCeP/GW lpqHwFY+z0tVwNN2NqVEUtc= =U7Xk -----END PGP SIGNATURE----- --=-=-=--