Date: Thu, 2 Oct 2014 13:48:00 -0700
From: "W. Trevor King" <wking@tremily.us>
To: Austin Clements <aclements@csail.mit.edu>
Subject: Re: [PATCH v4] lib: Simplify close and codify aborting atomic section
Message-ID: <20141002204800.GS3770@odin.tremily.us>
References: <87mw9ee0vf.fsf@csail.mit.edu>
	<1412277548-3445-1-git-send-email-aclements@csail.mit.edu>
	<20141002194134.GP3770@odin.tremily.us>
	<87k34idx4i.fsf@csail.mit.edu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="nqr+Djj1aAiKpg5f"
Content-Disposition: inline
In-Reply-To: <87k34idx4i.fsf@csail.mit.edu>
OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;
	url=http://tremily.us/pubkey.txt
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: notmuch@notmuchmail.org
Precedence: list


--nqr+Djj1aAiKpg5f
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 02, 2014 at 04:39:41PM -0400, Austin Clements wrote:
> On Thu, 02 Oct 2014, W. Trevor King wrote:
> > On Thu, Oct 02, 2014 at 03:19:08PM -0400, Austin Clements wrote:
> >> This patch simplifies notmuch_database_close to explicitly abort
> >> any outstanding transaction and then just call Database::close.
> >> This works for both read-only and read/write databases, takes
> >> care of committing changes, unifies the exception handling path,
> >> and codifies aborting outstanding transactions.
> >
> > I don't expect atomic blocks are particularly useful for read-only
> > connections.  If they aren't, I'd quibble with the =E2=80=9CThis works =
for
> > both read-only=E2=80=A6=E2=80=9D wording above.  If they are, I'd drop =
the
> > read/write
>=20
> It's true that atomic sections aren't very useful on a read-only
> database, but we do allow them for symmetry.

Heh, and they're no-ops since the beginning in 957f1ba3 (lib: Add
notmuch_database_{begin,end}_atomic, 2011-01-29).  So both the commit
message and read/write check make sense.  Quibble retracted.

Cheers,
Trevor

--=20
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

--nqr+Djj1aAiKpg5f
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJULbn/AAoJEG8/JgBt8ol8GeQP/1vp2y0f/I7ADIjn6izfaIS1
+u099CWat1dmicKblwR9QROkPxEi/qRFzliHfMg4umIxbWHQFYmYm5w7b80MnXIz
1y6ShwE/bDD1bf7omaRZBOmnNZ/GZQsZea+0wdA4VNozQA9M1qBCD0DhxTklgfwe
oh2v7SyXPjY92auUYSUG5+B4hcNlwL1uIlp6tlqgOuuxQ6BOEc4TVF288MYRwlRV
UrK1Qaz5Ngk5oMhfZphTz5LbWE2YYNIvu9njpKjIatgCjGL1UAxbYAHQ631ZOObG
7VrGGttamGfzPQ5srlVxtnClqT3rtjQc/mRU3TNAfIfCGpbv+D3BEVscegFJEWOZ
7OjbRath6Ow8wyms5wlQTBcyM3b0qnJYMS/W1D64nV7YkRKxvolIh1ehum1YcvmJ
/PJzFaUhQR/PBrL/Bvz6GbQONDNLsKrZ+M7abgkeA4sd/diaU+U11yGkgBTDHVuo
iirBXhMQtqqurKScnd5lUDwFjJpRr5Z0VXuu868uolznLHilQk8wgm31qXxXCcm4
TSghyT20EwIZZAcm+iZiZyDqoFyw6puLMsjTreT26+jtKEIDTL33USncaRxNqayi
BTRtmkZiUXf+SFLuKm3BeNFONx2S9bf9BeaKV+qCiy+q0pIRwZhc0KO/Z1SVqoZj
7fovHKHe34TAYtJCENBn
=xPir
-----END PGP SIGNATURE-----

--nqr+Djj1aAiKpg5f--