Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 98AB8431FC0 for ; Mon, 24 Sep 2012 03:44:11 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id befBQ-6d40V4 for ; Mon, 24 Sep 2012 03:44:11 -0700 (PDT) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 2A6FC431FAF for ; Mon, 24 Sep 2012 03:44:11 -0700 (PDT) Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.89.108] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1TG694-0004JF-0P; Mon, 24 Sep 2012 07:44:10 -0300 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1TG68y-0008Sx-J2; Mon, 24 Sep 2012 07:44:04 -0300 From: David Bremner To: Justus Winter <4winter@informatik.uni-hamburg.de>, notmuch@notmuchmail.org Subject: Re: RFC: Annotate internal_error with the attribute noreturn 2nd patchset In-Reply-To: <1348482717-10340-1-git-send-email-4winter@informatik.uni-hamburg.de> References: <20120922161256.GE26662@mit.edu> <1348482717-10340-1-git-send-email-4winter@informatik.uni-hamburg.de> User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/24.1.1 (x86_64-pc-linux-gnu) Date: Mon, 24 Sep 2012 07:44:04 -0300 Message-ID: <873927hf9n.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Sep 2012 10:44:11 -0000 Justus Winter <4winter@informatik.uni-hamburg.de> writes: > We need to discuss where those kind of macro definitions abstracting > away compiler differences should go. None of the files in util > includes notmuch-private.h, so I was unsure whether it's okay to put > them there. How about a new header file in util/ function-attributes.h or something like that? The util stuff is "lower level" than lib/ so it makes sense to me to put common stuff there. d