Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1810C431FD0 for ; Wed, 27 Apr 2011 12:59:19 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A4aTwZZjlrVZ for ; Wed, 27 Apr 2011 12:59:16 -0700 (PDT) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 83C19431FB5 for ; Wed, 27 Apr 2011 12:59:15 -0700 (PDT) Received: by wwi36 with SMTP id 36so1903391wwi.2 for ; Wed, 27 Apr 2011 12:59:12 -0700 (PDT) Received: by 10.227.149.142 with SMTP id t14mr2577577wbv.170.1303934352080; Wed, 27 Apr 2011 12:59:12 -0700 (PDT) Received: from localhost (202.69-240-81.adsl-dyn.isp.belgacom.be [81.240.69.202]) by mx.google.com with ESMTPS id b20sm663358wbb.67.2011.04.27.12.59.10 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 27 Apr 2011 12:59:11 -0700 (PDT) From: Pieter Praet To: Xavier Maillard , Carl Worth , Matthieu Lemerre , notmuch@notmuchmail.org Subject: Re: Warning when GMime is parsing broken email addresses In-Reply-To: References: <87ipzvk2xh.fsf@free.fr> <877hai3r82.fsf@yoom.home.cworth.org> User-Agent: Notmuch/0.5-98-g63c37b1 (http://notmuchmail.org) Emacs/23.1.50.1 (x86_64-pc-linux-gnu) Date: Wed, 27 Apr 2011 21:59:09 +0200 Message-ID: <87r58n8nzm.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2011 19:59:19 -0000 On Wed, 27 Apr 2011 18:30:09 +0200, Xavier Maillard wrote: > On Mon, 25 Apr 2011 15:23:41 -0700, Carl Worth wrote: > > On Wed, 17 Nov 2010 23:20:26 +0100, Matthieu Lemerre wrote: > > > Maybe it would also be interesting to add a warning/assertion to check > > > that all email adresses added to the database are correct email > > > addresses? I.e. check that the `addr' variable in _index_address_mailbox > > > always has a @. This check is in fact already done using the function > > > strchr, but a bad value is explicitly ignored... > > > > Hmm... we could add a warning like that. But I don't know how useful it > > would actually be. (I, for one, am currently not seeing any warnings > > From "notmuch new"---maybe I should fix that...). > > > > Since GMime is fixed upstream (as of version 2.4.18) another option > > would be to simply make the notmuch build system require a sufficiently > > new version of GMime in order to build. > > > > What do you think? > > My vote goes to the latter. Cleaner and really simple solution. > > /Xavier > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch I'd say both. Unfortunately, regressions are not uncommon, and regardless, it'd be nice to be notified when what we stuff in the db is not sane. It would however be a good idea IMHO to check email address more thorougly [1] than simply verifying whether an "@" is present. Peace -Pieter [1] http://www.regular-expressions.info/email.html